Page MenuHomeFreeBSD
Differential D26584

Rename acpi_iommu_get_dma_tag()
ClosedPublic
Actions

Authored by br on Sep 29 2020, 10:18 AM.
Tags
None
Referenced Files
F108617806: D26584.diff
Sun, Jan 26, 10:15 PM
Unknown Object (File)
Mon, Jan 13, 5:05 AM
Unknown Object (File)
Dec 10 2024, 8:29 PM
Unknown Object (File)
Nov 28 2024, 7:26 AM
Unknown Object (File)
Nov 18 2024, 8:57 PM
Unknown Object (File)
Nov 18 2024, 8:46 PM
Unknown Object (File)
Nov 17 2024, 9:40 PM
Unknown Object (File)
Nov 17 2024, 6:08 PM
View All 51 Files
Subscribers
imp

Details

Reviewers
andrew
kib
Commits
rS366257: o Rename acpi_iommu_get_dma_tag() -> iommu_get_dma_tag().
Summary

Rename acpi_iommu_get_dma_tag() as it does not seem to be ACPI dependend
Also on arm64 we may use it for FDT systems as well

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Sep 29 2020, 10:18 AM
br created this revision.
andrew accepted this revision.Sep 29 2020, 10:30 AM
This revision is now accepted and ready to land.Sep 29 2020, 10:30 AM
kib added inline comments.Sep 29 2020, 1:22 PM
sys/dev/acpica/acpi_pci.c
462–463

Wouldn't it be better to include iommu.h, instead of repeating the declaration ?

sys/dev/pci/pci.c
5686–5687

There too.

br updated this revision to Diff 77631.Sep 29 2020, 2:48 PM

Don't repeat iommu_get_dma_tag() declaration, include iommu.h instead.

This revision now requires review to proceed.Sep 29 2020, 2:48 PM
kib accepted this revision.Sep 29 2020, 2:51 PM
This revision is now accepted and ready to land.Sep 29 2020, 2:51 PM
Closed by commit rS366257: o Rename acpi_iommu_get_dma_tag() -> iommu_get_dma_tag(). (authored by br). · Explain WhySep 29 2020, 3:11 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS366257: o Rename acpi_iommu_get_dma_tag() -> iommu_get_dma_tag()..
Herald added a subscriber: imp. · View Herald TranscriptSep 29 2020, 3:11 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
7 lines
iommu/
2 lines
2 lines
2 lines
pci/
7 lines

Diff 77631

View Options

sys/dev/acpica/acpi_pci.c

Loading...
View Options

sys/dev/iommu/busdma_iommu.h

Loading...
View Options

sys/dev/iommu/busdma_iommu.c

Loading...
View Options

sys/dev/iommu/iommu.h

Loading...
View Options

sys/dev/pci/pci.c

Loading...