Fix dso_handle_check for PIE executables.
ClosedPublic
Actions

Authored by jhb on Nov 6 2020, 6:03 PM.

Details

Reviewers

emaste
andrew

Commits

rS367575: Fix dso_handle_check for PIE executables.

Summary

PIE executables use crtbeginS.o and have a non-NULL dso_handle as a result.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 6 2020, 6:03 PM

jhb created this revision.

Harbormaster completed remote builds in B34671: Diff 79272.Nov 6 2020, 6:03 PM

jhb added a child revision: D27127: Add C startup code tests for PIE binaries..Nov 6 2020, 6:04 PM

andrew accepted this revision.Nov 6 2020, 7:00 PM

This revision is now accepted and ready to land.Nov 6 2020, 7:00 PM

emaste accepted this revision.Nov 6 2020, 7:23 PM

Closed by commit rS367575: Fix dso_handle_check for PIE executables. (authored by jhb). · Explain WhyNov 10 2020, 7:07 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS367575: Fix dso_handle_check for PIE executables..

Herald added a subscriber: imp. · View Herald TranscriptNov 10 2020, 7:07 PM

jrtc27 added a subscriber: jrtc27.Nov 10 2020, 7:12 PM

jrtc27 added inline comments.

head/lib/csu/tests/fini_test.c
149	This message should be updated too; managed to miss that myself when reviewing the CheriBSD PR :(

Revision Contents
Changeset List

Path

Size

head/

lib/

csu/

tests/

fini_test.c

4 lines

Diff 79399

View Options

head/lib/csu/tests/fini_test.c

Fix dso_handle_check for PIE executables.ClosedPublicActions