Page MenuHomeFreeBSD
Differential D27497

Ensure the boot CPU is CPU 0 on arm64
ClosedPublic
Actions

Authored by andrew on Dec 7 2020, 1:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 7, 11:29 AM
Unknown Object (File)
Tue, Apr 7, 3:33 AM
Unknown Object (File)
Mon, Apr 6, 8:44 AM
Unknown Object (File)
Sun, Apr 5, 1:30 PM
Unknown Object (File)
Sun, Apr 5, 11:29 AM
Unknown Object (File)
Sun, Apr 5, 5:35 AM
Unknown Object (File)
Sat, Apr 4, 7:21 AM
Unknown Object (File)
Sat, Apr 4, 12:17 AM
View All Files
Subscribers
emaste
imp
mmel

Details

Reviewers
manu
mmel
Group Reviewers
arm64
Commits
rS368416: Ensure the boot CPU is CPU 0 on arm64
Summary

We assume the boot CPU is always CPU 0 on arm64. To allow for this reserve
cpuid 0 for the boot CPU in the ACPI and FDT cases but otherwise start the
CPU as normal. We then check for the boot CPU in start_cpu and return as if
it was started.

While here extract the FDT CPU init code into a new function to simplify
cpu_mp_start and return FALSE from start_cpu when the CPU fails to start.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Dec 7 2020, 1:05 PM
Herald added a reviewer: manu. · View Herald TranscriptDec 7 2020, 1:05 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Dec 7 2020, 1:05 PM
Harbormaster completed remote builds in B35230: Diff 80404.Dec 7 2020, 1:05 PM
andrew updated this revision to Diff 80406.Dec 7 2020, 1:21 PM

Simplify by only iterating once with CPU 0 being reserved

Harbormaster completed remote builds in B35231: Diff 80406.Dec 7 2020, 1:21 PM
andrew updated this revision to Diff 80407.Dec 7 2020, 1:25 PM
  • Use the correct ID in cpu_init_fdt
  • Copy a comment explaining why we don't increment the CPU ID to teh FDT code
  • Fix a typo in said comment
Harbormaster completed remote builds in B35232: Diff 80407.Dec 7 2020, 1:25 PM
andrew edited the summary of this revision. (Show Details)Dec 7 2020, 1:28 PM
mmel accepted this revision.Dec 7 2020, 4:37 PM
mmel added a subscriber: mmel.

Works for me and it's much better than my initial proposal.

This revision is now accepted and ready to land.Dec 7 2020, 4:37 PM
Closed by commit rS368416: Ensure the boot CPU is CPU 0 on arm64 (authored by andrew). · Explain WhyDec 7 2020, 5:55 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rS368416: Ensure the boot CPU is CPU 0 on arm64.

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
105 lines

Diff 80412

View Options

head/sys/arm64/arm64/mp_machdep.c

Loading...