Fall back to use the GICR address from the distributor struct
ClosedPublic
Actions

Authored by andrew on Nov 17 2020, 11:12 AM.

Details

Reviewers

f0andrey_gmail.com
manu

Group Reviewers

arm64

Commits

rS367841: Fall back to use the GICR address from the generic interrupt struct

Summary

When there is no ACPI redistributor sub-table in the MADT we need to
fall back to use the GICR base address from the GIC CPU interface
structure.

Handle this fallback when adding memory to the device and when counting
the number of redistributors.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Nov 17 2020, 11:12 AM

Herald added a reviewer: manu. · View Herald TranscriptNov 17 2020, 11:12 AM

Herald added a subscriber: emaste. · View Herald Transcript

andrew requested review of this revision.Nov 17 2020, 11:12 AM

Harbormaster completed remote builds in B34847: Diff 79646.Nov 17 2020, 11:12 AM

debug after https://people.freebsd.org/~andrew/0001-Add-debugging-to-the-GICv3-driver.patch https://dpaste.com/2QRXBMSVF

andrew added inline comments.Nov 18 2020, 3:32 PM

sys/arm64/arm64/gic_v3_acpi.c
142 ↗	(On Diff #79646)	Should be `ACPI_MADT_TYPE_GENERIC_INTERRUPT`
264 ↗	(On Diff #79646)	Should be `ACPI_MADT_TYPE_GENERIC_INTERRUPT`

progress mountroot not found
https://dpaste.com/6RKD9P7AA

afedorov added a subscriber: afedorov.Nov 18 2020, 8:02 PM

Success boot

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2020, 9:27 AM

Closed by commit rS367841: Fall back to use the GICR address from the generic interrupt struct (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rS367841: Fall back to use the GICR address from the generic interrupt struct.

Herald added a subscriber: imp. · View Herald TranscriptNov 19 2020, 9:27 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

gic_v3_acpi.c

47 lines

Diff 79744

View Options

head/sys/arm64/arm64/gic_v3_acpi.c

Fall back to use the GICR address from the distributor structClosedPublicActions