Tweak arm64's cpu_fetch_syscall_args(). This should make it possible
for the compiler to inline the memcpy().
Details
Details
- Reviewers
manu andrew - Group Reviewers
arm64 - Commits
- rS366456: Tweak arm64's cpu_fetch_syscall_args(). This should make it possible
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/arm64/arm64/trap.c | ||
|---|---|---|
| 138 ↗ | (On Diff #77748) | What does dst_ap point at? |
Comment Actions
Sigh, initialize dst_ap.
| sys/arm64/arm64/trap.c | ||
|---|---|---|
| 138 ↗ | (On Diff #77748) | Let's leave this review alone until I both tinderbox _and_ test it. |
| sys/arm64/arm64/trap.c | ||
|---|---|---|
| 147–148 ↗ | (On Diff #77839) | Won't this be wrong in the SYS_syscall an SYS___syscall cases? |
| sys/arm64/arm64/trap.c | ||
|---|---|---|
| 147–148 ↗ | (On Diff #77839) | I don't think so; in both cases - when calling through syscall(2), and when calling the "destination" syscall directly - the number of arguments to put into sa->args is the same; it's just the layout in the registers (or trapframe) that differs; this is taken care of a few lines above. |