Page MenuHomeFreeBSD
Differential D26629

Tweak arm64's cpu_fetch_syscall_args()
ClosedPublic
Actions

Authored by trasz on Oct 1 2020, 3:40 PM.
Tags
None
Referenced Files
F152512115: D26629.id77839.diff
Wed, Apr 15, 10:29 AM
F152442557: D26629.diff
Wed, Apr 15, 12:07 AM
F152441939: D26629.id77748.diff
Wed, Apr 15, 12:02 AM
Unknown Object (File)
Tue, Apr 14, 1:34 PM
Unknown Object (File)
Tue, Apr 14, 12:56 PM
Unknown Object (File)
Tue, Apr 14, 12:46 PM
Unknown Object (File)
Sun, Apr 12, 5:11 PM
Unknown Object (File)
Sun, Apr 12, 10:03 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
andrew
Group Reviewers
arm64
Commits
rS366456: Tweak arm64's cpu_fetch_syscall_args(). This should make it possible
Summary

Tweak arm64's cpu_fetch_syscall_args(). This should make it possible
for the compiler to inline the memcpy().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Oct 1 2020, 3:40 PM
Herald added a reviewer: manu. · View Herald TranscriptOct 1 2020, 3:40 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
Harbormaster completed remote builds in B33928: Diff 77730.Oct 1 2020, 3:40 PM
trasz requested review of this revision.Oct 1 2020, 3:40 PM
trasz retitled this revision from Tweak amd64's cpu_fetch_syscall_args() to Tweak arm64's cpu_fetch_syscall_args().Oct 1 2020, 3:40 PM
trasz edited the summary of this revision. (Show Details)
trasz added a reviewer: ARM.
trasz updated this revision to Diff 77748.Oct 1 2020, 6:51 PM

Try to make it more buildable.

Harbormaster completed remote builds in B33935: Diff 77748.Oct 1 2020, 6:51 PM
andrew added inline comments.Oct 1 2020, 6:53 PM
sys/arm64/arm64/trap.c
138 ↗(On Diff #77748)

What does dst_ap point at?

trasz updated this revision to Diff 77753.Oct 1 2020, 7:44 PM

Sigh, initialize dst_ap.

sys/arm64/arm64/trap.c
138 ↗(On Diff #77748)

Let's leave this review alone until I both tinderbox _and_ test it.

Harbormaster completed remote builds in B33937: Diff 77753.Oct 1 2020, 8:24 PM
andrew edited reviewers, added: arm64; removed: ARM.Oct 2 2020, 8:00 AM
trasz updated this revision to Diff 77839.Oct 4 2020, 1:14 PM

Fix tinderbox.

Harbormaster completed remote builds in B33972: Diff 77839.Oct 4 2020, 1:15 PM
trasz added a comment.Oct 4 2020, 2:10 PM

I've tested it, it works and is ready for review.

andrew accepted this revision.Oct 5 2020, 5:14 PM
andrew added inline comments.
sys/arm64/arm64/trap.c
147–148 ↗(On Diff #77839)

Won't this be wrong in the SYS_syscall an SYS___syscall cases?

This revision is now accepted and ready to land.Oct 5 2020, 5:14 PM
trasz added inline comments.Oct 5 2020, 6:37 PM
sys/arm64/arm64/trap.c
147–148 ↗(On Diff #77839)

I don't think so; in both cases - when calling through syscall(2), and when calling the "destination" syscall directly - the number of arguments to put into sa->args is the same; it's just the layout in the registers (or trapframe) that differs; this is taken care of a few lines above.

Closed by commit rS366456: Tweak arm64's cpu_fetch_syscall_args(). This should make it possible (authored by trasz). · Explain WhyOct 5 2020, 6:46 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS366456: Tweak arm64's cpu_fetch_syscall_args(). This should make it possible.

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
21 lines

Diff 77909

View Options

head/sys/arm64/arm64/trap.c

Loading...