Sorry for the delay. Will try to review today/tomorrow.

Please allow me one more day to review the changes.

Do pre-commit sync: fix NOINET case.

In D4605#102190, @hselasky wrote:

Ping - any reviewers active on this one?

sorry, will take a look today.

In D4794#101759, @bz wrote:

People had been asking for this for IPv4 and I did the patch but never committed it as the penalty was noticeable. We should not lose these features in favour of simplicity but make them perform well when designing things. Having had per-address counters has been very valuable in the last years for IPv6 to debug and account various things.

I've updated the patch.
IPv6 accounting for most common case (non-fragmented packets) should be slightly better (no ifa ref/unref cost). It is still costy, however, due to IF_ADDR_RLOCK() which is rwlock.
Sending frags is also accounted the same way which may degrade performance for that path.

Update IPv6 part (add precise accounting using newly-added in6_accountoifa()) per bz@ comments.

In D4794#101759, @bz wrote:

This is a straight reject to the idea from my view. Sorry.
People had been asking for this for IPv4 and I did the patch but never committed it as the penalty was noticeable. We should not lose these features in favour of simplicity but make them perform well when designing things. Having had per-address counters has been very valuable in the last years for IPv6 to debug and account various things. And sorry, using a firewall is not a solution.

I thought it won't be easy but I had to start with something :)
Okay. So for IPv6 situation is not that complicated:
function like inc_ia6_countrers(ifp, addr, opackets, obytes) which internally finds appropriate ifa under ifaddr lock and increments pcpu counters under that lock, w/o the need to do heavy refcounting. It would both improve the performance and increase accuracy.

Do pre-commit sync.

Sorry, I totally missed the point that I have to commit it myself :)

Update once again to clarify arp_fillheader() behavior.

Finally fix ip_arpintr() reply error handling.

Address glebius@ comments and sync to recent HEAD.

Mark, big thanks for adding QSFP28 stuff.
Looks OK to me (minor comment below).

In D4102#95769, @mike-karels.net wrote:

I haven't reviewed this as closely as I should. However, if I read this correctly, this is a new caching mechanism that:

• is not currently used for caching

Mike,
Thanks for the comments.
I probably should have written more detailed summary. Let me try to rephrase it.

Update patch to reflect recent netinet6/ lltable changes.

Thanks for updating the patch!
Looks OK, several small comments inline

Update diff to exclude infiniband part and address comments.

According to the summary, it looks ok. Ensuring entire inet6/ code would work in all similar cases require (probably much) more work :)

Thanks for reviewing that one.

Update to sync with recent changes.

Remove sbin/ifconfig debug.

Do pre-commit sync.

Meant D4102 in last comment