Page MenuHomeFreeBSD

Add SFF-8024 Extended Specification Compliance
ClosedPublic

Authored by markb_mellanox.com on Dec 21 2015, 9:55 AM.

Details

Summary

The Extended Specification Compliance Codes identify the electronic or optical
interfaces which are not included in SFF-8472 Optical and Cable Variants
Specification Compliance or SFF-8636 Specification Compliance Codes.

See: ftp://ftp.seagate.com/sff/SFF-8636.PDF

ftp://ftp.seagate.com/sff/SFF-8024.PDF

Sponsored by: Mellanox Technologies

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markb_mellanox.com retitled this revision from to Add SFF-8024 Extended Specification Compliance.
markb_mellanox.com updated this object.
markb_mellanox.com edited the test plan for this revision. (Show Details)
melifaro accepted this revision.Dec 21 2015, 10:20 AM
melifaro edited edge metadata.

Mark, big thanks for adding QSFP28 stuff.
Looks OK to me (minor comment below).

sbin/ifconfig/sfp.c
408 ↗(On Diff #11509)

It would be great to have some sort of define like SFF_8632_EXT_COMPLIANCE instead of the raw value.

This revision is now accepted and ready to land.Dec 21 2015, 10:20 AM
markb_mellanox.com edited edge metadata.
  • Introduce a new define (SFF_8636_EXT_COMPLIANCE) in case we deal with extended class table.
  • Rename SFF_8436_CODE_E1040G to SFF_8436_CODE_E1040100G, indicate we can deal with 10/40/100, It should be noted that we also have 25G in the extended table, but this is how the table is named in SFF-8636 Rev 2.6.
This revision now requires review to proceed.Dec 21 2015, 12:38 PM
melifaro accepted this revision.Dec 21 2015, 1:09 PM
melifaro edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 1:09 PM
This revision was automatically updated to reflect the committed changes.

Sorry, I totally missed the point that I have to commit it myself :)