inet6: Do not assume every interface has ip6 enabled
ClosedPublic
Actions

Authored by kp on Dec 11 2015, 7:49 PM.

Details

Reviewers

melifaro
hrs

Group Reviewers

network

Commits

rS292219: inet6: Do not assume every interface has ip6 enabled.

Summary

Certain interfaces (e.g. pfsync0) do not have ip6 addresses (in other words,
ifp->if_afdata[AF_INET6] is NULL). Ensure we don't panic when the MTU is
updated.

pfsync interfaces will never have ip6 support, because it's explicitly disabled
in in6_domifattach().

PR: 205194

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp updated this revision to Diff 11143.Dec 11 2015, 7:49 PM

kp retitled this revision from to inet6: Do not assume every interface has ip6 enabled.

kp updated this object.

kp edited the test plan for this revision. (Show Details)

kp set the repository for this revision to rS FreeBSD src repository - subversion.

kp added a project: network.

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2015, 7:49 PM

admin_support.od.ua added a subscriber: admin_support.od.ua.Dec 11 2015, 8:34 PM

melifaro added a subscriber: melifaro.Dec 11 2015, 8:50 PM

According to the summary, it looks ok. Ensuring entire inet6/ code would work in all similar cases require (probably much) more work :)

sys/netinet6/in6.c
2427 ↗	(On Diff #11143)	Well, the function is supposed to return MTU value. 46 is definitely better than panic, but It would probably be better to return ifp->if_mtu.

This revision is now accepted and ready to land.Dec 11 2015, 9:13 PM

melifaro added a reviewer: network.Dec 11 2015, 9:13 PM

kp added inline comments.Dec 11 2015, 10:14 PM

sys/netinet6/in6.c
2427 ↗	(On Diff #11143)	You're quite right. We should do what the caller (if_getmtu_family()) does if it can't get a better answer and return ifp->if_mtu.