In D38575#878653, @philip wrote:

I'm okay with this in principle (though I've not tested it).

Would it make sense to reduce the diff to upstream by sticking the #include <net/bpf.h> under #ifdef __FreeBSD__ and the rest of the file under #else?

Or is it not worth bothering?

libpcap: Make pcap/bpf.h a minimal wrapper around net/bpf.h

In D38575#878410, @cy wrote:

The affected ports should be able to use ports/net/libpcap?

In D38575#877791, @antoine wrote:

Hi,
In may 2018 I reported that some ports were broken due to the upgrade (non-exhaustive list):

• packetdrill
• spamd
• vde2
• xprobe2

These are suggestions based on our Matrix discussion. It lets readers know once at the beginning of the chapter that any package can be custom built from the port, but we only describe how to install the package for each application.

In D38221#870150, @grembo wrote:

@markj @jrm I just committed be146a923dbda66f50c6b04b406da790837f6287 (cgit link) which addresses the issue in a more generic fashion (since we had these kinds of errors pop up over and over again). Even though I tested this locally and it seems to work as expected, it would be great if you could verify this at your end as well.

Jake, do you want me to commit this?

In D38221#868793, @karels wrote:

fwiw, there are separate archanist-php8[012]-* ports, and I arbitrarily chose 82.

Looks good to me. Builds and applies fine with php81, which is currently the default PHP version in ports.

Here are a few minor comments. I've only partially made it through the chapter, but I'll submit now since I've run out of time for today

Thanks for the quick review/approval.

Builds fine on a recent amd64 CURRENT system as well. Thanks

Closing. Committed after approval from ashish in a private conversation.

Upstream fixed all the tests and re-tagged.

In D37975#862788, @fuz_fuz.su wrote:

Build-tested succesfully with Poudriere on armv7 arm64 FreeBSD 13.1.

Upstream has updated to 2.5.46

Yuri and Robert, adding you since you both seem interested in this port. poudriere testport looks good for 12/13/14 adm64 and 12/13 i386. I don't have any arm or lower tier hardware to test, so if you're interested in those platforms, please chime in. I'm still looking into occasional seg faults running the FEL and now CONTRAST-FEL tests.

Will do. Thanks for the quick review.

I poudriere tested in i386/amd64 12/13 and 14adm64 CURRENT jails. An exp run is probably warranted.

This was just a test of git-arc for an update to devel/freebsd-git-devtools.

In D37616#856997, @carlavilla wrote:

{F53053992}

{F53054021}

{F53054047}

{F53054066}

{F53054068}

devel/cl-asdf-sbcl: New port to install ASDF FASL for SBCL

Remove some commented code in asdf-init.lisp