beinstall.sh: Check correct exit status
ClosedPublic
Actions

Authored by jrm on Dec 19 2022, 4:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 27, 4:04 PM

	Unknown Object (File)
	Thu, Apr 23, 6:53 PM

	Unknown Object (File)
	Thu, Apr 23, 2:20 AM

	Unknown Object (File)
	Wed, Apr 22, 1:26 AM

	Unknown Object (File)
	Wed, Apr 22, 1:17 AM

	Unknown Object (File)
	Mon, Apr 20, 4:13 AM

	Unknown Object (File)
	Fri, Apr 17, 8:10 AM

	Unknown Object (File)
	Sat, Apr 4, 10:05 PM

View All 96 Files

Subscribers

imp

Details

Reviewers

will
emaste
bapt

Commits

rGa0c50eda2987: beinstall.sh: Check correct exit status

Summary

When retrieving the timestamp of the last commit using git-show(1), do
not pipe the output to head(1), otherwise the value in $? will be for
head(1) and not git-show(1).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrm created this revision.Dec 19 2022, 4:26 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 19 2022, 4:26 AM

jrm requested review of this revision.Dec 19 2022, 4:26 AM

Harbormaster completed remote builds in B48757: Diff 114268.Dec 19 2022, 4:26 AM

jrm added a reviewer: emaste.Dec 19 2022, 4:29 AM

bapt accepted this revision.Jan 3 2023, 2:24 PM

This revision is now accepted and ready to land.Jan 3 2023, 2:24 PM

Closed by commit rGa0c50eda2987: beinstall.sh: Check correct exit status (authored by jrm). · Explain WhyJan 3 2023, 2:33 PM

This revision was automatically updated to reflect the committed changes.

jrm added a commit: rGa0c50eda2987: beinstall.sh: Check correct exit status.

Revision Contents
Changeset List

Path

Size

tools/

build/

beinstall.sh

2 lines

Diff 114729

View Options

beinstall.sh: Check correct exit statusClosedPublicActions