Page MenuHomeFreeBSD

devel/arcanist-lib: Handle null argument passed to strlen()
AbandonedPublic

Authored by jrm on Jan 9 2023, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 12:41 AM
Unknown Object (File)
Fri, Oct 3, 10:51 AM
Unknown Object (File)
Fri, Oct 3, 9:03 AM
Unknown Object (File)
Sep 16 2025, 12:45 AM
Unknown Object (File)
Aug 17 2025, 10:38 PM
Unknown Object (File)
Aug 13 2025, 9:44 PM
Unknown Object (File)
Jun 28 2025, 1:11 PM
Unknown Object (File)
May 2 2025, 7:11 PM
Subscribers

Details

Reviewers
grembo
Summary

Problem description:

  • ArcanistDiffWorkflow.php:getDiffOntoTargets() tries to determine the current branch name by calling ArcanistGitAPI.php:getBranchName()
  • getBranchName() returns NULL when working on a detached HEAD
  • getDiffOntoTargets() calls strlen() with the branch name, which now fails with a NULL argument.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49029
Build 45918: arc lint + arc unit