Page MenuHomeFreeBSD

devel/arcanist-lib: Handle null argument passed to strlen()
AbandonedPublic

Authored by jrm on Jan 9 2023, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 6:06 AM
Unknown Object (File)
Nov 12 2023, 4:57 AM
Unknown Object (File)
Oct 11 2023, 4:01 AM
Unknown Object (File)
May 4 2023, 5:38 AM
Unknown Object (File)
Apr 6 2023, 6:58 PM
Unknown Object (File)
Mar 27 2023, 3:27 PM
Unknown Object (File)
Jan 29 2023, 8:24 AM
Unknown Object (File)
Jan 10 2023, 5:56 PM
Subscribers

Details

Reviewers
grembo
Summary

Problem description:

  • ArcanistDiffWorkflow.php:getDiffOntoTargets() tries to determine the current branch name by calling ArcanistGitAPI.php:getBranchName()
  • getBranchName() returns NULL when working on a detached HEAD
  • getDiffOntoTargets() calls strlen() with the branch name, which now fails with a NULL argument.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49029
Build 45918: arc lint + arc unit