In D24829#546556, @freqlabs wrote:In D24829#546555, @debdrup wrote:For what it's worth (not much, since I'm not yet a doc commiter), the manual page looks good.
Channelling my inner bcr, I must remember to bump the date before committing!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 14 2020
May 14 2020
May 13 2020
May 13 2020
Comment about the BUGS section.
In D24635#542261, @gbergling_gmail.com wrote:In D24635#542252, @bcr wrote:Did that grammar fix come from upstream? If not, we should report it there and then get the updated version.
I send schwarze@openbsd.org an e-mail and reported the grammar mistake. I think that should work.
@0mp: Do you think we should keep the .Tn?
I lean towards committing the change as it is and handle the man page macros in a follow-up commit.
My old key expired, this is the new one.
Looks good on the man page side of things, after removing the one extra "the" I found. Thanks for writing the man page!
May 12 2020
May 12 2020
bcr accepted D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..
OK from manpages.
OK from manpages.
May 10 2020
May 10 2020
bcr added a comment to D22507: Reorder the entries of hardware commercial page and add ThinkPenguin.
Any updates on this? I think after make the changes commented above, it can be committed.
bcr accepted D23850: netgraph: Allow larger messages in communication between kernel and user-space.
OK from manpages.
OK for the man page part of the change.
Approved!
May 9 2020
May 9 2020
Update the /etc/make.conf entries regarding
Mention the existence of /etc/defaults/vendor.conf
I think that's a valid reason and I'm OK with the change. Thank you, Sergio.
Correct the location of the dtrace-toolkit when
May 8 2020
May 8 2020
Updates to the Kerberos section:
I'll commit a slightly updated version soon. Thank you for the update.
Add the new freebsd-quarterly-calls mailing list.
Looks good. I'm taking care of the commit. I saw the review just now.
May 7 2020
May 7 2020
Is this related to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241683 ?
May 6 2020
May 6 2020
OK from manpages.
May 5 2020
May 5 2020
Add HISTORY sections to document when this
Looks good to me, so I'll go ahead and commit those. Thank you, Gordon!
Fix broken links in the man page by pointing to a
Take in Dru Lavigne's commit bit due to inactivity.
Man page comments
Add Mariusz for Casper/Capsicum review. Not too deep, just a general "do the dates/releases make sense".
May 3 2020
May 3 2020
Add references for the most important man7
OK, I think this is good to have. I'll get it commited. Thank you!
Fix various, mostly minor errors in man pages like:
Add HISTORY sections to build(7), crypto(7),
bcr accepted D24271: Add HISTORY sections to build(7), crypto(7), ffs(7), growfs(7) and diskless(8).
I'll get this committed. Thanks!
May 1 2020
May 1 2020
OK from docs.
A number of (much needed) updates and corrections to the
Fix a number of the following issues in man4:
Looks good, I'll get this committed. Thank you for these changes!
Apr 30 2020
Apr 30 2020
Add more man page folks for help.
Did that grammar fix come from upstream? If not, we should report it there and then get the updated version.
Add a new manual page for unionfs(5), written by
Add HISTORY sections to disk(9), driver(9), and
Great, thanks for these changes. I'll get them committed.
Looks good to me.
OK from manpages.
I'm OK with the change itself. Just want to make sure than @imp is fine with the content removal (it's available in the repo if someone needs it).
Apr 29 2020
Apr 29 2020
bcr added a comment to D24617: Add additional EINVAL information about wrong block size to read(2)/write(2).
In D24617#541952, @lwhsu wrote:Don't forget .Dd :-)
Add HISTORY section to domain(9).
Looks good to to me. Thank you!
You can check the man page using textproc/igor and "mandoc -Tlint".
The man page looks good. Don't forget to bump the .Dd when committing.
When copying and pasting the code in the EXAMPLE
Thank you. I'll get this committed to the tree.
Apr 27 2020
Apr 27 2020
That looks good. Can you commit the change yourself or should I do it?
Apr 23 2020
Apr 23 2020
Thanks for these fixes. Ready to commit!
What's the status on this? Seems like all issues were resolved and it is ready for commit?
Ok from manpages. Can't say much about the actual content, though.
Apr 22 2020
Apr 22 2020
Good to go. Thanks for checking these sites.
Apr 20 2020
Apr 20 2020
Good to go. Thanks for submitting the patch.
Apr 19 2020
Apr 19 2020
Apr 17 2020
Apr 17 2020
Looks good to me and I think at this point, it makes more sense to recommend other desktop-oriented BSDs.
Apr 14 2020
Apr 14 2020
Apr 13 2020
Apr 13 2020
Great, thanks for the quick fix. The man page part is approved, then.
bcr added a comment to D24316: Make sonewconn overflow messages have per-socket rate-limits and values.
Language suggestion for the man page.
OK for the man page change. Thanks!
Apr 12 2020
Apr 12 2020
Good to go. Thanks for taking care of the PR. It will be a great addition to the website.
Apr 8 2020
Apr 8 2020
Still looks good after these changes.
Looks good. Did you run "mandoc -Tlint" and igor over it?
bcr added a comment to D24321: Style revisions, accessibility enhancements, and ports statistics updates.
Overall, this is a great addition and update. Thank you.
There are other things that need to be fixed, but that should come in a separate follow-up commit to not blow up this review with more changes.
Ready to for commit. Thanks, @jrm !
Apr 6 2020
Apr 6 2020
OK, thank you. Approved!
bcr added a comment to D24305: status/report-template.xml: Improve Documentation category description.
Oxford comma, the rest is fine.
Apr 5 2020
Apr 5 2020
Looks good to me. Getting feedback from other developers is good practice after all.
Cleaning up these entries from time to time is good to not have stale information around. User groups can always be added again.
Apr 2 2020
Apr 2 2020
OK from docs. Thanks for the update.
Apr 1 2020
Apr 1 2020
Thanks, good to go!
Typo fix, the rest looks good.
Mar 31 2020
Mar 31 2020
bcr accepted D24234: ipfw(8): Introduce src-ip4/dst-ip4 and src-ipv4/dst-ipv4 specifiers, make src-ip/dst-ip dual-stack.
OK from manpages. Don't forget to bump the .Dd when you commit this change. Thank you!
Mar 30 2020
Mar 30 2020
OK from manpages.
Mar 29 2020
Mar 29 2020
With a .Dd bump, you're good to go.
Thanks for this update!
Mar 27 2020
Mar 27 2020
Looks good from the doc side of things. Can't say much about the language other than that it's great to have updated translations!
Release Sergio Carlavilla from mentorship.
@allanjude : Is that OK, considering the upstream changes to those man pages?
Mar 26 2020
Mar 26 2020
OK from manpages.
Mar 22 2020
Mar 22 2020
bcr accepted D24151: [handbook] Add a section to about switching pkg from the quarterly branch to the latest branch.
Good, looks better now. Commit it!