Page MenuHomeFreeBSD

Sort & dedupe getopt flags for daemon
Needs ReviewPublic

Authored by darius-dons.net.au on Jul 18 2019, 4:04 AM.

Details

Reviewers
rpokala
pstef
Group Reviewers
manpages
Summary

As the title says.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rpokala requested changes to this revision.Jul 18 2019, 5:18 AM

In addition to fixing the getopt() line, please upload a full diff, as described on the FreeBSD wiki: https://wiki.freebsd.org/action/show/Phabricator#Create_a_Revision_via_Web_Interface

daemon.getopt/daemon.c
104 โ†—(On Diff #59863)

You lost three close-parens and an open-brace!

This revision now requires changes to proceed.Jul 18 2019, 5:18 AM

Sorry for the noise, I can't drive Git..

Now this includes parts of D20969 ๐Ÿ˜•

The core of this change -- sort and de-dupe getopt() and sort the cases -- is fine. Please try again with just that part, and leave the rest as part of D20969 as intended.

Now this includes parts of D20969 ๐Ÿ˜•

The core of this change -- sort and de-dupe getopt() and sort the cases -- is fine. Please try again with just that part, and leave the rest as part of D20969 as intended.

As per IRC, it's a post D20969 version (although it predates the octal change so context is a bit misleading but the actual diff is right)

bcr added a subscriber: bcr.

The man page looks good. Don't forget to bump the .Dd when committing.