Differential D24219

Allow TCP backhole detection to be enabled per protocol
ClosedPublic
Actions

Authored by tuexen on Mar 29 2020, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 20, 6:59 AM

	Unknown Object (File)
	Sun, Apr 20, 4:10 AM

	Unknown Object (File)
	Sun, Apr 20, 1:12 AM

	Unknown Object (File)
	Sun, Apr 20, 12:47 AM

	Unknown Object (File)
	Sun, Apr 20, 12:46 AM

	Unknown Object (File)
	Sat, Apr 19, 11:27 PM

	Unknown Object (File)
	Sat, Apr 19, 11:06 PM

	Unknown Object (File)
	Sat, Apr 19, 10:48 PM

View All 74 Files

Subscribers

Details

Reviewers

jtl
rrs
rscheff
bz

Group Reviewers

manpages
transport

Commits

rS359487: Allow the TCP backhole detection to be disabled at all, enabled only

Summary

Allow the TCP blackhole detection to be enabled for only for IPv4, only for IPv6, and for IPv4 and IPv6.
The current blackhole detection might classify a temporary outage as an MTU issue and reduces permanently the MSS.
Since the consequences of such a reduction due to a misclassification are much more drastically for IPv4 than for IPv6, let the administrator enable it for IPv6 only.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Mar 29 2020, 10:41 PM

Herald added a reviewer: manpages. · View Herald TranscriptMar 29 2020, 10:41 PM

Herald added a reviewer: transport. · View Herald Transcript

Herald added subscribers: melifaro, imp. · View Herald Transcript

Harbormaster completed remote builds in B30170: Diff 69984.Mar 29 2020, 10:41 PM

Same change for RACK and BBR.

Harbormaster completed remote builds in B30173: Diff 69988.Mar 29 2020, 11:48 PM

OK from manpages.

LGTM

This revision is now accepted and ready to land.Mar 31 2020, 1:43 PM

Closed by commit rS359487: Allow the TCP backhole detection to be disabled at all, enabled only (authored by tuexen). · Explain WhyMar 31 2020, 3:55 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS359487: Allow the TCP backhole detection to be disabled at all, enabled only.

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man4/

24 lines

sys/

netinet/

tcp_stacks/

12 lines

13 lines

14 lines

Diff 70064

head/share/man/man4/tcp.4

Loading...

head/sys/netinet/tcp_stacks/bbr.c

Loading...

head/sys/netinet/tcp_stacks/rack.c

Loading...

head/sys/netinet/tcp_timer.c

Loading...