Page MenuHomeFreeBSD

it_IT/Makefile: Add articles directory
ClosedPublic

Authored by salvadore on Wed, Mar 25, 5:25 PM.

Details

Summary

Add articles directory to it_IT.ISO8859-15/Makefile and update .po and .xml files to fix Italian documentation build.

Test Plan
$ DOCDIR=/tmp/D24184 make all install clean

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

salvadore created this revision.Wed, Mar 25, 5:25 PM
dbaio requested changes to this revision.Wed, Mar 25, 5:57 PM

I was testing this change and found another issue:

[dbaio:.../doc_https/it_IT.ISO8859-15]$ DOCDIR=/tmp/D24184 make all install clean
Warning: Object directory not changed from original /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15
===> articles (all)
Warning: Object directory not changed from original /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles
===> articles/bsdl-gpl (all)
install /usr/home/dbaio/FreeBSD/doc_https/share/xml/catalog-cwd.xml /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/catalog-cwd.xml
echo '<!ENTITY enbase "../..">' > /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/autogen.ent
echo '<!ENTITY base "..">' >> /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/autogen.ent
env XML_CATALOG_FILES="file:///usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/catalog-cwd.xml  file:///usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/share/xml/catalog.xml  file:///usr/home/dbaio/FreeBSD/doc_https/share/xml/catalog.xml  file:///usr/local/share/xml/catalog" /usr/local/bin/xmllint --nonet --noent --valid --dropdtd --xinclude /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml > article.parsed.xml.tmp
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:8: namespace error : Namespace prefix default on address is not defined
/personname><affiliation> <default:address xmlns="http://docbook.org/ns/docbook"
                                                                               ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:8: element default:address: validity error : No declaration for attribute xmlns of element default:address
/personname><affiliation> <default:address xmlns="http://docbook.org/ns/docbook"
                                                                               ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:9: element default:address: validity error : No declaration for element default:address
          </default:address> </affiliation></author>
                            ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:9: element affiliation: validity error : Element affiliation content does not follow the DTD, expecting (shortaffil? , jobtitle* , (org? | (orgname? , orgdiv* , address*))), got (default:address )
          </default:address> </affiliation></author>
                                           ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:105: parser error : AttValue: " or ' expected
ema. Ciò portò ad una versione modificata della GPL chiamata <link xlink:href=
                                                                               ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:105: parser error : attributes construct error
ema. Ciò portò ad una versione modificata della GPL chiamata <link xlink:href=
                                                                               ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:105: parser error : Couldn't find end of Start Tag link line 105
ema. Ciò portò ad una versione modificata della GPL chiamata <link xlink:href=
                                                                               ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:105: parser error : Opening and ending tag mismatch: para line 100 and link
k xlink:href=\"http://www.opensource.org/licenses/lgpl-license.php\">LGPL</link>
                                                                               ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:105: parser error : Opening and ending tag mismatch: sect1 line 100 and para
e che è stato linkato dinamicamente ad una libreria sottoposta alla LGPL.</para
                                                                               ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:109: parser error : Opening and ending tag mismatch: article line 100 and sect1
</sect1>
        ^
/usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl/article.xml:111: parser error : Extra content at the end of the document
<sect1 xml:id="orphaning">
^
*** Error code 1

Stop.
make[2]: stopped in /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles/bsdl-gpl
*** Error code 1

Stop.
make[1]: stopped in /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15/articles
*** Error code 1

Stop.
make: stopped in /usr/home/dbaio/FreeBSD/doc_https/it_IT.ISO8859-15

what's the version of itstool you are using?

docproj-2.0_14 and itstool-2.0.6 here. There is a bug with 2.0.5.

You will need to regenerate articles/bsdl-gpl/article.xml with make tran, to fix that.

Then please, test a full build in the it_IT.ISO8859-15 directory.
$ DOCDIR=/tmp/D24184 make all install clean

This revision now requires changes to proceed.Wed, Mar 25, 5:57 PM
salvadore updated this revision to Diff 69868.Wed, Mar 25, 8:46 PM

Update .po and .xml file so that now the test build works.

salvadore edited the summary of this revision. (Show Details)Wed, Mar 25, 8:49 PM
salvadore edited the test plan for this revision. (Show Details)
dbaio accepted this revision.Wed, Mar 25, 9:00 PM

thanks @salvadore
LGTM

This revision is now accepted and ready to land.Wed, Mar 25, 9:00 PM
bcr accepted this revision as: bcr.Fri, Mar 27, 5:38 PM

Looks good from the doc side of things. Can't say much about the language other than that it's great to have updated translations!

tcberner accepted this revision.Fri, Mar 27, 9:35 PM

Lgtm.

This revision was automatically updated to reflect the committed changes.