Phabricator has been hitting false build positives, don't worry.
I'll stand down as reviewer... I have too much to do on other fronts :(.

Minor enhancement in libthread_db, move a multiplier to the second
argument to reduce risk of an overflow in the first argument.

Forced update to restart the build.

Update: just for reference ... I will be committing some
cleanups independently as suggested by ngie.

Some notes here b/c Phabricator doesn't let me reply:

In D9954#205869, @ngie wrote:

That's not the only fun... I'd probably incorporate this patch as well, but commit the calloc change separately:

$ svn diff usr.sbin/lpr/chkprintcap/
Index: usr.sbin/lpr/chkprintcap/chkprintcap.c
===================================================================
--- usr.sbin/lpr/chkprintcap/skimprintcap.c    (revision 314942)
+++ usr.sbin/lpr/chkprintcap/skimprintcap.c    (working copy)
@@ -81,8 +81,9 @@
        enum {NO_CONTINUE, WILL_CONTINUE, BAD_CONTINUE} is_cont, had_cont;
        enum {CMNT_LINE, ENTRY_LINE, TAB_LINE, TABERR_LINE} is_type, had_type;

-       skinf = malloc(sizeof(struct skiminfo));
-       memset(skinf, 0, sizeof(struct skiminfo));
+       skinf = calloc(1, sizeof(struct skiminfo));
+       if (skinf == NULL)
+               return (NULL);

        pc_file = fopen(pcap_fname, "r");
        if (pc_file == NULL) {

Add gad@ as he is the maintainer.
For the record: Coverity doesn't report any of these.

In D9915#205626, @delphij wrote:

Please do not commit as-is.

In D3043#205126, @ngie wrote:

Is this review still valid?

Committed as r314669 but I missed the "Differential Revision" reference.

In D9879#204076, @imp wrote:

This is fine, though the commit message could use some work.

Why not remove I586_CPU also?

In D9879#204076, @imp wrote:

This is fine, though the commit message could use some work.

Why not remove I586_CPU also?

Remove some changes, at least one false positive.

In D9007#195939, @pstef wrote:

In D9007#193594, @ngie wrote:

Thanks for the explanations -- please provide this in your commit message.

Cheers!

Sorry to bother you, but I have some doubts and I'd prefer to ask here first than to discuss on -committers when it's too late.

It's certainly better to ask early, no need to apologize.