lib: make use of reallocarray(3).
ClosedPublic
Actions

Authored by pfg on Mar 12 2017, 4:16 PM.

Details

Reviewers

ngie
delphij
bapt

Commits

rS317265: lib: initial use of reallocarray(3).

Summary

Use reallocarray(3) when reallocation involves a multiplication.
AFAICT, these libraries that are not meant to be portable so
reallocarray(3) is not a maintainance concern.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pfg created this revision.Mar 12 2017, 4:16 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 12 2017, 4:16 PM

Minor enhancement in libthread_db, move a multiplier to the second
argument to reduce risk of an overflow in the first argument.

Harbormaster completed remote builds in B8019: Diff 26190.Mar 12 2017, 4:56 PM

Harbormaster completed remote builds in B8020: Diff 26191.Mar 12 2017, 5:43 PM

I'm ok with the non-contributed source code being adapted to the new pattern (sidenote: I'm a bit sad that these libraries aren't in contrib/)..

lib/libiconv_modules/ISO2022/citrus_iso2022.c
262–263 ↗	(On Diff #26191)	I would leave this hunk alone since it's citrus iconv is shared between FreeBSD and IllumOS.
lib/libusbhid/usage.c
116 ↗	(On Diff #26191)	This code came from NetBSD. I'd probably leave it alone.

This revision is now accepted and ready to land.Apr 18 2017, 1:28 AM

TBH, I am wondering the usefulness fo these replacements.
It is not clear if overflows are possible at all. OTOH I am pretty sure the changes won't hurt.

lib/libiconv_modules/ISO2022/citrus_iso2022.c
262–263 ↗	(On Diff #26191)	This comes from NetBSD/citrus. Illumos has it because we are their upstream for this, and illumos will be adopting reallocarray(3) as well.