I have verified the bug you mention is unrelated to this patch. It happens on vanilla HEAD. I'd like to commit this patch and then look at the bug you mention.

If you're seeing this on an image without the patch then it's not the patch that's the problem. If that's the case then please open a PR against netmap and, if you like assign it to me but it ought to not block committing this work.

I don't see that here either in the VM or outside of one. Here is the uname of my VM:

Seems like a reasonable smoke test to me. Please make the requested changes and commit.

I agreed with Andrew's comments but once they're addressed this should be good to go in. Always a good idea to add markj@ to these reviews, as I just did. Also, what hardware was this tested on?

Please update this review with an overview, similar to what you'd use in a commit message, of the change and the reason for the change.

Please update this review with an overview, similar to what you'd use in a commit message, of the change and the reason for the change.

Please update this review with an overview, similar to what you'd use in a commit message, of the change and the reason for the change.

I do not believe that this, or Matt's, change should make doing the right thing with the routing system any more difficult than it already is. I think it's time we pushed either this change or the associated change into the tree. The other routing work is longer term.

I'd also like to point out that this is about hosts communicating via TCP, and not FreeBSD acting as a router. As such this, or something quite similar, ought to go into the tree irrespective of the potential reworking of the routing system for increasing the speed of FreeBSD as a router.

Sounds good. Defaulting to on is the right thing in HEAD then. You'll have to change that on an MFC.

Was there an update to this based on new work? It's generally useful and ought to go in, with stated modifications of course.

Is there a reason to have this under a build constant? Is there any reason we don't want this to be the default behavior?

I'd change the default number of ticks to 100 (1Hz) rather than 10 (10Hz)

Did a bunch of tabs get converted to spaces or vice versa? We want the code to adhere to style(9) tab scheme.

I'd like to see this broken down into a smaller set of changes. Single large changes like this are hard to review, debug, and, if there are problems, revert.

Looks good to me. Approved for commit.

Bump. Can this be committed?

This looks fine but I'm hoping that bz@ (now added) will take a look as well.

Please commit with
Approved by: gnn (mentor)