Differential D4591

Update netstat to use sysctls for IPsec statistics
ClosedPublic
Actions

Authored by gnn on Dec 16 2015, 1:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 21, 9:09 PM

	Unknown Object (File)
	Fri, Aug 21, 9:09 PM

	Unknown Object (File)
	Fri, Aug 21, 9:08 PM

	Unknown Object (File)
	Thu, Aug 20, 11:05 AM

	Unknown Object (File)
	Wed, Aug 19, 7:25 PM

	Unknown Object (File)
	Wed, Aug 19, 2:54 PM

	Unknown Object (File)
	Wed, Aug 19, 7:21 AM

	Unknown Object (File)
	Sat, Jul 25, 5:32 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS292394: Switch the IPsec related statistics to using the built in sysctl

Summary

The IPSec code exposes sysctls for all stats, there is no need to read KVM to get these stats. Fixing this issue makes the -z (zero) flag work correctly for all IPSec statistics which has the positive knock on effect of allowing benchmarks, testing and debugging to be done with a reasonable set of statistics.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gnn updated this revision to Diff 11336.Dec 16 2015, 1:59 AM

gnn retitled this revision from to Update netstat to use sysctls for IPsec statistics.

gnn updated this object.

gnn edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptDec 16 2015, 1:59 AM

gnn updated this object.Dec 16 2015, 2:02 AM

gnn added a reviewer: network.

Looks good to me, except two lines in ipsec_stats(), that are not wrapped according style(9).

This revision is now accepted and ready to land.Dec 16 2015, 12:02 PM

Closed by commit rS292394: Switch the IPsec related statistics to using the built in sysctl (authored by gnn). · Explain WhyDec 17 2015, 2:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

netstat/

28 lines

10 lines

Diff 11363

head/usr.bin/netstat/ipsec.c

Loading...

head/usr.bin/netstat/main.c

Loading...