sfxge: parse packets for TSO early in if_transmit
ClosedPublic
Actions

Authored by arybchik on Nov 29 2015, 8:03 AM.

Details

Reviewers

Commits

rS291584: sfxge: parse packets for TSO early in if_transmit

Summary

Submitted by: Artem V. Andreev <Artem.Andreev at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

Build tested, driver loaded/unloaded.
It was tested using netperf, netpipe and sfnt-pingpong with IPv4/IPv6,
VLAN or non-VLAN -- it works just fine.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 10560.Nov 29 2015, 8:03 AM

arybchik retitled this revision from to sfxge: parse packets for TSO early in if_transmit.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added a reviewer: gnn.

Herald added a subscriber: imp. · View Herald TranscriptNov 29 2015, 8:03 AM

arybchik added a subscriber: network.Nov 29 2015, 8:04 AM

Is there a reason to have this under a build constant? Is there any reason we don't want this to be the default behavior?

The main reason to have it under conditional is to minimize the code difference between FreeBSD 8/9 and 10/current. The former do not have space in mbuf to store parsing results. Yes, I'm committing to head which has the space and can have it always enabled, but I'd keep it to minimize difference between in-tree and out-of-tree driver (which may be built and basically tested on FreeBSD 8.4 and 9.3).