Page MenuHomeFreeBSD

Enable LLDB by default on platforms where we build Clang
ClosedPublic

Authored by emaste on Dec 17 2013, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 20, 1:54 AM
Unknown Object (File)
May 17 2024, 10:01 AM
Unknown Object (File)
May 7 2024, 10:19 AM
Unknown Object (File)
May 2 2024, 7:26 AM
Unknown Object (File)
Apr 27 2024, 12:42 PM
Unknown Object (File)
Apr 26 2024, 8:31 PM
Unknown Object (File)
Apr 26 2024, 8:28 PM
Unknown Object (File)
Apr 26 2024, 8:28 PM

Details

Reviewers
jhb
gnn
Test Plan

Check that lldb is built if no WITH_ or WITHOUT_ in src.conf

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from Enable LLDB by default on amd64 to Enable LLDB by default on amd64 and arm64.
emaste changed the visibility from "All Users" to "Public (No Login Required)".

Rebase and enable for arm64 as well

jhb added a reviewer: jhb.
jhb added a subscriber: jhb.

Will be nice to get more platforms on the default yes list. :)

This revision is now accepted and ready to land.Oct 20 2015, 9:17 PM
imp added inline comments.
share/mk/src.opts.mk
249

I'dd add LLDB to DEFAULT_YES options unconditionally.
And I'd change this .if to to be the contrapositive of the one on line 241.

share/mk/src.opts.mk
249

I think we can instead enable LLDB by default on the same platforms that build Clang by default (i.e., i386, amd64, arm*, powerpc*)

emaste retitled this revision from Enable LLDB by default on amd64 and arm64 to Enable LLDB by default on platforms where we build Clang.
emaste edited edge metadata.

On 32- and 64-bit x86, arm, and powerpc we build Clang by default. Build LLDB by default on these as well.

This revision now requires review to proceed.Oct 20 2015, 10:06 PM

For reference, times from a few test builds:

make -j16                                          buildworld  12448.13s user 2164.26s system 1249% cpu 19:29.06 total
make -j16 WITH_DEBUG_FILES=yes                     buildworld  12860.29s user 2484.72s system 1285% cpu 19:53.55 total
make -j16                         WITH_LLDB=yes    buildworld  13638.69s user 2472.67s system 1296% cpu 20:42.47 total
make -j16 WITH_DEBUG_FILES=yes    WITH_LLDB=yes    buildworld  13992.22s user 2526.42s system 1306% cpu 21:04.76 total
make -j16 WITHOUT_DEBUG_FILES=yes WITHOUT_LLDB=yes buildworld  12557.10s user 2479.58s system 1260% cpu 19:53.12 total
emaste edited edge metadata.
emaste edited subscribers, added: gnn; removed: gjb.

For now just explicitly default LLDB to YES on arm/arm64/amd64, and NO elsewhere.

I would like to build it in those cases where clang is /usr/bin/cc, but it's not yet usable for live debugging on i386 so there's no point in enabling it there yet. We could use BROKEN_OPTIONS to disable it on i386, but that's not quite right: it will build on i386, and can debug core files from other architectures or connect to remote targets.

gnn added a reviewer: gnn.
This revision is now accepted and ready to land.Dec 16 2015, 3:18 PM