Page MenuHomeFreeBSD

ixgbe(4): Update to version 3.1.13-k
ClosedPublic

Authored by erj on Nov 17 2015, 12:41 AM.
Referenced Files
F83396240: D4186.id10251.diff
Thu, May 9, 10:27 PM
Unknown Object (File)
Thu, May 2, 7:28 PM
Unknown Object (File)
Fri, Apr 26, 1:46 AM
Unknown Object (File)
Apr 6 2024, 10:52 AM
Unknown Object (File)
Apr 6 2024, 5:16 AM
Unknown Object (File)
Apr 6 2024, 1:12 AM
Unknown Object (File)
Mar 3 2024, 7:51 AM
Unknown Object (File)
Feb 22 2024, 10:25 PM

Details

Summary

Adds support for two new devices: X552 SFP+ 10 GbE, and the single port version of X550T.

Along with more of a changelist that I need to compile.

Test Plan

We've run various tests on the standalone version that this version of the driver is derived from, along with compiling this diff into a CURRENT kernel and verifying that the kernel boots, and the interfaces appear in ifconfig and pass traffic. (On a system with an X520 and an X540).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

erj retitled this revision from to ixgbe(4): Update to version 3.1.13-k.
erj updated this object.
erj edited the test plan for this revision. (Show Details)
erj added reviewers: scottl, gnn, adrian.
erj set the repository for this revision to rS FreeBSD src repository - subversion.
erj added a project: Intel Networking.

It wasn't clear from the summary that if this just adds new devices or also updates existing ones.

Do you guys run any sort of performance tests to make sure you don't make existing drivers worse with new changes? If not, that is a good/necessary thing to do.

gnn requested changes to this revision.Nov 18 2015, 2:34 PM
gnn edited edge metadata.

I'd like to see this broken down into a smaller set of changes. Single large changes like this are hard to review, debug, and, if there are problems, revert.

This revision now requires changes to proceed.Nov 18 2015, 2:34 PM

Ok, will do. I wish there was a nice way to lump a bunch of diffs together into one revision in Phabricator, though.

That said, could someone do an "arc patch D4186" and tell me if this compiles and doesn't egregiously break something they're running?

gnn edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2015, 7:00 PM

applies cleanly, build started.

sbruno edited edge metadata.

I see no objections here, so this should be committed.

This revision was automatically updated to reflect the committed changes.