sfxge: avoid TSO packets collapses if packet header uses 2 segments
ClosedPublic
Actions

Authored by arybchik on Nov 30 2015, 1:33 PM.

Details

Reviewers

Commits

rS291569: sfxge: avoid TSO packets collapses if packet header uses 2 segments

Summary

It is really observed in the case of VLAN over sfxge interface.
Also this change makes total value equal to 35 which is default assumed
by the kernel for if_hw_tsomaxsegcount.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

Build tested, driver loaded/unloaded.
Tested using heavy TCP traffic over VLAN with HW-assisted VLAN insertion
disabled.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 10599.Nov 30 2015, 1:33 PM

arybchik retitled this revision from to sfxge: avoid TSO packets collapses if packet header uses 2 segments.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added a reviewer: gnn.

Herald added a subscriber: imp. · View Herald TranscriptNov 30 2015, 1:33 PM

arybchik added a subscriber: network.Nov 30 2015, 1:34 PM

gnn accepted this revision.Nov 30 2015, 10:26 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Nov 30 2015, 10:26 PM

Closed by commit rS291569: sfxge: avoid TSO packets collapses if packet header uses 2 segments (authored by arybchik). · Explain WhyDec 1 2015, 6:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

sfxge_tx.h

4 lines

Diff 10619

View Options

head/sys/dev/sfxge/sfxge_tx.h

sfxge: avoid TSO packets collapses if packet header uses 2 segmentsClosedPublicActions