Add an option to use rfc6675 based pipe/inflight bytes calculation in cubic.
ClosedPublic
Actions

Authored by hiren on Nov 19 2015, 3:25 AM.

Details

Reviewers

Group Reviewers

network
transport

Commits

rS292011: Add an option to use rfc6675 based pipe/inflight bytes calculation in cubic.

Summary

Add an option to use rfc6675 based pipe/inflight bytes calculation in cubic.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hiren updated this revision to Diff 10324.Nov 19 2015, 3:25 AM

hiren retitled this revision from to Add an option to use rfc6675 based pipe/inflight bytes calculation in cubic..

hiren updated this object.

hiren edited the test plan for this revision. (Show Details)

hiren added a reviewer: transport.

Herald added a subscriber: imp. · View Herald TranscriptNov 19 2015, 3:25 AM

hiren added a reviewer: network.Nov 19 2015, 7:06 AM

hiren removed a subscriber: imp.

j-nitrology.com added a subscriber: j-nitrology.com.Nov 19 2015, 9:38 AM

gnn added a subscriber: gnn.Nov 19 2015, 9:41 PM

gnn added inline comments.

sys/netinet/cc/cc_cubic.c
305 ↗	(On Diff #10324)	Minor nit. Why note set pipe to 0 at line 302?

hiren added inline comments.Nov 19 2015, 9:45 PM

sys/netinet/cc/cc_cubic.c
305 ↗	(On Diff #10324)	I thought style(9) doesn't like combining declaration and assignment.

gnn accepted this revision.Nov 24 2015, 10:20 PM

gnn added a reviewer: gnn.

This revision is now accepted and ready to land.Nov 24 2015, 10:20 PM

Closed by commit rS292011: Add an option to use rfc6675 based pipe/inflight bytes calculation in cubic. (authored by hiren). · Explain WhyDec 9 2015, 7:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

cc/

cc_cubic.c

13 lines

Diff 10962

View Options

head/sys/netinet/cc/cc_cubic.c

Add an option to use rfc6675 based pipe/inflight bytes calculation in cubic.ClosedPublicActions