sysbeep: Adjust interface to take a duration as a sbt
ClosedPublic
Actions

Authored by imp on Oct 24 2021, 5:56 AM.

Details

Reviewers

jhb
glebius
manu
des
tsoome

Commits

rG87586bff11ec: sysbeep: Adjust interface to take a duration as a sbt
rG072d5b98c431: sysbeep: Adjust interface to take a duration as a sbt

Summary

Change the 'period' argument to 'duration' and change its type to
sbintime_t so we can more easily express different durations.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42359
Build 39247: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 24 2021, 5:56 AM

imp created this revision.

Harbormaster completed remote builds in B42327: Diff 97347.Oct 24 2021, 5:56 AM

imp added a child revision: D32620: vt(4): Connect to teken's TP_SETBELLPD.Oct 24 2021, 5:56 AM

imp edited the test plan for this revision. (Show Details)Oct 24 2021, 6:00 AM

imp added reviewers: jhb, glebius, manu, des.

Thanks for doing this:)

This revision is now accepted and ready to land.Oct 24 2021, 6:11 AM

• hselasky added a subscriber: • hselasky.Oct 24 2021, 11:52 AM

• hselasky added inline comments.

sys/kern/kern_cons.c
673	Hi, Could this function generate a devd event, with pitch and duration, for implementing via a real audio device? --HPS

Thanks for taking a constructive approach to the heated discussion! I'm no expert in this part of kernel, so please treat my "Accepted" more as "Liked" rather than "Approved" :)

glebius accepted this revision.Oct 25 2021, 3:49 PM

mav added a subscriber: mav.Oct 26 2021, 1:09 AM

mav added inline comments.

sys/kern/kern_cons.c
685	I am curios whether up to 50% variation of the duration due to C_PREL(1) will be too noticeable or even annoying. May be we should be more strict here.

mav added inline comments.Oct 26 2021, 1:13 AM

sys/kern/kern_cons.c
684–686	Here should better be beeping = 1 now to not overflow. I don't see a point to expand beeping to spintime_t.

imp added inline comments.Oct 26 2021, 1:19 AM

sys/kern/kern_cons.c
684–686	Yea, nobody has a beep more than 1s, but it really is a bool and has been logically back to 386BSD, even though bool didn't exist then :)...
685	Likely. I think C_PREL(4) or 5 is in order...