minidump: Use the provided dump bitset
ClosedPublic
Actions

Authored by mhorne on Sep 16 2021, 6:40 PM.

Details

Reviewers

manu
markj
kib
jhb
stevek
luporl

Commits

rG233ec6b12b56: minidump: Use the provided dump bitset
rG10fe6f80a6c8: minidump: Use the provided dump bitset

Summary

When constructing the set of dumpable pages, use the bitset provided by
the state argument, rather than assuming vm_page_dump invariably. For
normal kernel minidumps this will be a pointer to vm_page_dump, but when
dumping the live system it will not.

To do this, the functions in vm_dumpset.h are extended to accept the
desired bitset as an argument. Note that this provided bitset is assumed
to be derived from vm_page_dump, and therefore has the same size.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41550
Build 38439: arc lint + arc unit

Event Timeline

mhorne created this revision.Sep 16 2021, 6:40 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 16 2021, 6:40 PM

Herald added subscribers: Contributor Reviews (src), jhibbits, emaste and 2 others. · View Herald Transcript

mhorne requested review of this revision.Sep 16 2021, 6:40 PM

mhorne added a parent revision: D31991: minidump: Use provided msgbuf pointer.

Harbormaster completed remote builds in B41550: Diff 95263.Sep 16 2021, 6:40 PM

mhorne added a child revision: D31993: Allow minidumps to be performed on the live system.Sep 16 2021, 6:40 PM

mhorne added reviewers: markj, kib, jhb, stevek.Sep 16 2021, 6:44 PM

mhorne added a parent revision: D31989: minidump: Parameterize minidumpsys().

mhorne edited subscribers, added: allanjude; removed: Contributor Reviews (src).

This is mostly mechanical. state->dump_bitset should be used inside each minidump_machdep.c, and vm_page_dump everywhere else. The one exception to this is powerpc's dumpsys_scan_pmap() method, which is extended to also accept a bitset argument.

markj added inline comments.Sep 16 2021, 7:05 PM

sys/amd64/amd64/pmap.c
4953	I think it'd be better to provide a helper which fixes the `vm_page_dump` parameter. e.g., rename `dump_add_page()` to `vm_page_dump_add(`) and make have `dump_add_page()` just be `vm_page_dump_add(vm_page_dump, pa)`. It feels a bit silly to force all of the interface consumers outside of minidumpsys() to specify the global context which exists solely for the minidumpsys() implementation.