Differential D27728

linuxkpi: Add shrinker support
ClosedPublic
Actions

Authored by manu on Dec 22 2020, 6:19 PM.

Details

Reviewers

Group Reviewers

linuxkpi

Commits

rG2c95fb753fb2: linuxkpi: Add shrinker support

Summary

A driver can register a shrinker that will be called when the kernel
wants to free some memory.
Add support for that in linuxkpi and call the registered shrinkers
when the lowmem event is triggered.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Dec 22 2020, 6:19 PM

Herald added a subscriber: emaste. · View Herald TranscriptDec 22 2020, 6:19 PM

manu requested review of this revision.Dec 22 2020, 6:19 PM

bz added a subscriber: bz.Dec 22 2020, 7:12 PM

bz added inline comments.

sys/compat/linuxkpi/common/src/linux_shrinker.c
47	I always wonder if we should document that fields are initialised by at least adding KASSERT()s? I guess I've been calling too many NULL function pointers lately elsewhere which were never initialised or checked on registration.
70	batch is not needed until line 79; can it be initialised after the initial return?
77	No { } needed.
107	Long line.

manu added inline comments.Dec 23 2020, 9:51 AM

sys/compat/linuxkpi/common/src/linux_shrinker.c
47	you mean adding something like KASSERT(s->count_objects == NULL, ...) ? Anyway yeah I think that I should check that both function pointer are not NULL here.
70	Will change.
77	printf debugging leftover :) I'll change that.
107	Will change.