Page MenuHomeFreeBSD
Differential D19830

Create sys/reg.h for the common code previously in machine/reg.h
ClosedPublic
Actions

Authored by andrew on Apr 5 2019, 12:35 PM.
Tags
None
Referenced Files
F107135831: D19830.id94287.diff
Fri, Jan 10, 4:34 PM
F107135368: D19830.id55837.diff
Fri, Jan 10, 4:23 PM
Unknown Object (File)
Thu, Jan 9, 2:15 AM
Unknown Object (File)
Mon, Jan 6, 3:53 PM
Unknown Object (File)
Fri, Dec 27, 8:50 AM
Unknown Object (File)
Thu, Dec 12, 9:38 PM
Unknown Object (File)
Dec 9 2024, 5:10 PM
Unknown Object (File)
Dec 4 2024, 5:19 AM
View All Files
Subscribers
bcran
bdragon
emaste
imp
jhibbits
markj
rgrimes
rpokala

Details

Reviewers
jhb
manu
markj
imp
gnn
Group Reviewers
bhyve
Commits
rGe5e2c7ffa0f7: Create sys/reg.h for the common code previously in machine/reg.h
rGb792434150d6: Create sys/reg.h for the common code previously in machine/reg.h
Summary

This is in preperation for adding PT_GETREGSET

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23534
Build 22538: arc lint + arc unit

Event Timeline

andrew created this revision.Apr 5 2019, 12:35 PM
Herald added a reviewer: manu. · View Herald TranscriptApr 5 2019, 12:35 PM
Herald added subscribers: bdragon, jhibbits. · View Herald Transcript
Harbormaster completed remote builds in B23534: Diff 55837.Apr 5 2019, 12:35 PM
andrew added a child revision: D19831: Add PT_GETREGSET.Apr 5 2019, 12:37 PM
andrew updated this revision to Diff 94268.Aug 27 2021, 11:15 AM

Rebase

Herald added a reviewer: bhyve. · View Herald TranscriptAug 27 2021, 11:15 AM
Herald added subscribers: bcran, rgrimes, rpokala, imp. · View Herald Transcript
Harbormaster completed remote builds in B41237: Diff 94268.Aug 27 2021, 11:15 AM
markj added a subscriber: markj.Aug 27 2021, 3:21 PM
markj added inline comments.
sys/mips/include/reg.h
98

Is this forward declaration needed?

sys/x86/include/reg.h
247

I think this declaration isn't needed anymore.

andrew updated this revision to Diff 94287.Aug 27 2021, 4:04 PM

Remove unneeded forward declarations

Harbormaster completed remote builds in B41239: Diff 94287.Aug 27 2021, 4:04 PM
markj accepted this revision as: markj.Aug 28 2021, 12:12 AM
This revision is now accepted and ready to land.Aug 28 2021, 12:12 AM
imp accepted this revision.Aug 28 2021, 12:25 AM
jhb accepted this revision.Aug 30 2021, 5:59 PM
jhb added inline comments.
sys/x86/include/reg.h
247

The comment isn't needed, but the function still exists. It is shared between DTrace and fill_regs().

Closed by commit rGb792434150d6: Create sys/reg.h for the common code previously in machine/reg.h (authored by andrew). · Explain WhyOct 26 2021, 6:24 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGb792434150d6: Create sys/reg.h for the common code previously in machine/reg.h.
Herald added a reviewer: gnn. · View Herald TranscriptOct 26 2021, 6:24 PM
jhb added a commit: rGe5e2c7ffa0f7: Create sys/reg.h for the common code previously in machine/reg.h.May 22 2022, 1:01 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
2 lines
2 lines
ia32/
1 line
arm/
arm/
2 lines
include/
9 lines
arm64/
arm64/
2 lines
include/
20 lines
i386/
i386/
2 lines
2 lines
kern/
3 lines
3 lines
mips/
include/
2 lines
14 lines
mips/
2 lines
1 line
powerpc/
include/
11 lines
powerpc/
2 lines
2 lines
2 lines
riscv/
include/
12 lines
riscv/
2 lines
sparc64/
include/
12 lines
sparc64/
2 lines
sys/
2 lines
32 lines
x86/
include/
14 lines

Diff 55837

View Options

sys/amd64/amd64/db_trace.c

Loading...
View Options

sys/amd64/amd64/machdep.c

Loading...
View Options

sys/amd64/ia32/ia32_reg.c

Loading...
View Options

sys/arm/arm/machdep_kdb.c

Loading...
View Options

sys/arm/include/reg.h

Loading...
View Options

sys/arm64/arm64/machdep.c

Loading...
View Options

sys/arm64/include/reg.h

Loading...
View Options

sys/i386/i386/db_trace.c

Loading...
View Options

sys/i386/i386/machdep.c

Loading...
View Options

sys/kern/kern_exec.c

Loading...
View Options

sys/kern/sys_process.c

Loading...
View Options

sys/mips/include/md_var.h

Loading...
View Options

sys/mips/include/reg.h

Loading...
View Options

sys/mips/mips/freebsd32_machdep.c

Loading...
View Options

sys/mips/mips/machdep.c

Loading...
View Options

sys/powerpc/include/reg.h

Loading...
View Options

sys/powerpc/powerpc/elf32_machdep.c

Loading...
View Options

sys/powerpc/powerpc/exec_machdep.c

Loading...
View Options

sys/powerpc/powerpc/machdep.c

Loading...
View Options

sys/riscv/include/reg.h

Loading...
View Options

sys/riscv/riscv/machdep.c

Loading...
View Options

sys/sparc64/include/reg.h

Loading...
View Options

sys/sparc64/sparc64/machdep.c

Loading...
View Options

sys/sys/ptrace.h

Loading...
View Options

sys/sys/reg.h

Loading...
View Options

sys/x86/include/reg.h

Loading...