Unneeded

Unneeded

Do we need any per-CPU data for GICv5? If not this can change to say so

Not needed as later headers include it. It was previously needed for the __FBSDID macro, but that has been removed from .c files.

Should this use the sanitised register value?

We should create macros for these

And this

Do we have a macro for this?

We can remove some of these, they were there so I could check which registers have been implemented

It would be useful to add a comment here explaining why registers are unimplemented, e.g. is RAZ/WI because IRS_IDR0.VIRT == 0

Don't we need LPIs for IPIs? It looks like Linux checks for it.

Should we check IRS_IST_BASER.VALID != 1 first? If it's valid then this is read-only

We should only write when IRS_IST_BASER.Valid != 1

And the same for SPI

You could move GICV5_PPIS_PER_REG and GICV5_PPI_COUNT to a header & use them here

Do we need this panic?

This should return an error

Is there a reason to put this here & not in a vgic specific function?