Page MenuHomeFreeBSD
Differential D60373

acpi: Tasks: Ensure sane values for number of tasks and threads
Needs ReviewPublic
Actions

Authored by olce on Mon, Oct 5, 5:00 PM.
Tags
None
Referenced Files
F175355770: D60373.id.diff
Sat, Oct 10, 6:11 AM
F175339182: D60373.diff
Sat, Oct 10, 2:55 AM
F175280290: D60373.id188735.diff
Fri, Oct 9, 4:12 PM
F175280284: D60373.id188734.diff
Fri, Oct 9, 4:12 PM
F175275438: D60373.diff
Fri, Oct 9, 3:49 PM
F175265930: D60373.diff
Fri, Oct 9, 2:04 PM
Unknown Object (File)
Fri, Oct 9, 2:02 AM
Unknown Object (File)
Fri, Oct 9, 1:46 AM
View All 19 Files
Subscribers
imp

Details

Reviewers
obiwac
jkim
emaste
Summary

Make sure that these are set to sane values even on silly tunables:

  • There must be at least one thread to process the 'acpi_taskq'.
  • Ensure that the maximum number of tasks is at least 0. Setting it to a very low positive number is still silly in practice as it will cause AcpiOSExecute() to fail more often then not, but at least won't cause huge bogus memory allocations when allocating acpi_tasks[].

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77726
Build 74609: arc lint + arc unit

Event Timeline

olce created this revision.Mon, Oct 5, 5:00 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Oct 5, 5:00 PM
Harbormaster completed remote builds in B77726: Diff 188734.Mon, Oct 5, 5:00 PM
olce requested review of this revision.Mon, Oct 5, 5:00 PM
olce updated this revision to Diff 188735.Mon, Oct 5, 5:03 PM
olce edited the summary of this revision. (Show Details)
  • Good diff (isolated commit instead of a bunch of 3).
Harbormaster completed remote builds in B77727: Diff 188735.Mon, Oct 5, 5:03 PM
olce added a child revision: D60374: acpi: Tasks: Size the number of tasks with the actual number of CPUs.Mon, Oct 5, 5:04 PM
emaste added inline comments.Wed, Oct 7, 3:33 PM
sys/dev/acpica/Osd/OsdSchedule.c
97

would it be reasonable to make acpi_max_tasks unsigned?

emaste added inline comments.Wed, Oct 7, 3:34 PM
sys/dev/acpica/Osd/OsdSchedule.c
97

Oh, not if we're going to use -1 as a sentinel value :)

olce marked 2 inline comments as done.Thu, Oct 8, 8:46 AM
olce added inline comments.
sys/dev/acpica/Osd/OsdSchedule.c
97

Yes, in D60374.

olce marked an inline comment as done.Thu, Oct 8, 9:34 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
Osd/
27 lines
9 lines

Diff 188734

View Options

sys/dev/acpica/Osd/OsdSchedule.c

Loading...
View Options

sys/dev/acpica/acpivar.h

Loading...