Page MenuHomeFreeBSD
Differential D59628

nvme: derive CC.CSS from CAP.CSS instead of hardcoding the NVM set
ClosedPublic
Actions

Authored by seuros on Sun, Sep 13, 8:56 AM.
Tags
Referenced Files
Unknown Object (File)
Sat, Oct 3, 1:01 PM
Unknown Object (File)
Sat, Oct 3, 12:05 PM
Unknown Object (File)
Sat, Oct 3, 11:10 AM
Unknown Object (File)
Sat, Oct 3, 9:29 AM
Unknown Object (File)
Sat, Oct 3, 12:15 AM
Unknown Object (File)
Fri, Oct 2, 9:04 PM
Unknown Object (File)
Fri, Oct 2, 6:52 PM
Unknown Object (File)
Fri, Oct 2, 4:35 PM
View All 71 Files
Subscribers
None

Details

Reviewers
imp
dab
adrian
ngie
Commits
rGb99595c9c7f8: nvme: derive CC.CSS from CAP.CSS instead of hardcoding the NVM set
Summary

CC.CSS was always writting zero, which is a reserved encoding on a
controller that does not support the NVM command set.
Select 111b on admin-only controllers and 110b when the
I/O command set mechanism is available.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

seuros requested review of this revision.Sun, Sep 13, 8:56 AM
seuros created this revision.
Harbormaster completed remote builds in B76818: Diff 186563.Sun, Sep 13, 8:56 AM
seuros added a project: drivers.Sun, Sep 13, 10:05 AM
seuros added a parent revision: D59627: nvme: honor FLBAS Format Index Upper when selecting the LBA format.
seuros added a child revision: D59631: nvme: honor CRTO for the controller ready timeout.
seuros updated this revision to Diff 186579.Sun, Sep 13, 10:27 AM

format

Harbormaster completed remote builds in B76827: Diff 186579.Sun, Sep 13, 10:27 AM
ngie added a comment.Mon, Sep 21, 10:46 PM

I couldn't find the constants in the NVMe spec. Could you please help me understand where you are getting this info from?

sys/dev/nvme/nvme_ctrlr.c
366

Is this indentation correct?

405–412

style(9) nit.

seuros updated this revision to Diff 187368.Tue, Sep 22, 2:51 AM

style nit

Harbormaster completed remote builds in B77152: Diff 187368.Tue, Sep 22, 2:51 AM
seuros marked an inline comment as done.Tue, Sep 22, 3:03 AM
In D59628#1374245, @ngie wrote:

I couldn't find the constants in the NVMe spec. Could you please help me understand where you are getting this info from?

https://nvmexpress.org/wp-content/uploads/NVM-Express-Base-Specification-Revision-2.4-Ratified-2026.07.31.pdf page 107

sys/dev/nvme/nvme_ctrlr.c
366

It show correct in vim and zed.

ngie accepted this revision.Tue, Sep 22, 3:34 AM
This revision is now accepted and ready to land.Tue, Sep 22, 3:34 AM
imp accepted this revision.Tue, Sep 22, 5:00 AM
adrian accepted this revision.Wed, Sep 23, 12:45 AM
Closed by commit rGb99595c9c7f8: nvme: derive CC.CSS from CAP.CSS instead of hardcoding the NVM set (authored by seuros). · Explain WhyThu, Sep 24, 2:21 PM
This revision was automatically updated to reflect the committed changes.
seuros added a commit: rGb99595c9c7f8: nvme: derive CC.CSS from CAP.CSS instead of hardcoding the NVM set.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
9 lines
13 lines

Diff 187607

View Options

sys/dev/nvme/nvme.h

Loading...
View Options

sys/dev/nvme/nvme_ctrlr.c

Loading...