bhyve: Add an option to prevent automatic restart in monitor mode
ClosedPublic
Actions

Authored by bnovkov on Aug 23 2026, 1:04 PM.

Details

Reviewers

andrew
markj

Group Reviewers

bhyve

Commits

rGef821f9ba66a: bhyve: Add an option to prevent automatic restart in monitor mode

Summary

Monitor mode will currently unconditionally restart the guest if it
reboots, which can be incovenient in certain situations (e.g., resetting
the guest after a panic).

Address this by introducing a way to prevent automatic guest restarts
in monitor mode.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75980
Build 72863: arc lint + arc unit

Event Timeline

bnovkov created this revision.Aug 23 2026, 1:04 PM

Herald added a reviewer: andrew. · View Herald TranscriptAug 23 2026, 1:04 PM

Herald added subscribers: ziaee, bcran, rgrimes and 2 others. · View Herald Transcript

bnovkov requested review of this revision.Aug 23 2026, 1:04 PM

Harbormaster completed remote builds in B75980: Diff 184783.Aug 23 2026, 1:04 PM

Thank you!

usr.sbin/bhyve/amd64/bhyverun_machdep.c
207	This is a backward compat break, shouldn't we handle the old name with bhyve_cfg_warn()?
usr.sbin/bhyve/bhyve.8
349	You might clarify that this option has no effect unless `-M` is specified or monitor.enabled is configured. I think the SIGNAL HANDLING section should also explain how signal handling interacts with monitor mode and the new no_reboot option.
usr.sbin/bhyve/bhyve_config.5
239	You changed this to `monitor.enabled`.

Address @markj's comments

Harbormaster completed remote builds in B77034: Diff 186989.Thu, Sep 17, 7:07 PM

markj accepted this revision as: markj.Thu, Sep 17, 7:52 PM

markj added inline comments.

usr.sbin/bhyve/aarch64/bhyverun_machdep.c
121	Usage message wasn't updated.
usr.sbin/bhyve/riscv/bhyverun_machdep.c
115	Usage message wasn't updated.

This revision is now accepted and ready to land.Thu, Sep 17, 7:52 PM

bnovkov added inline comments.Thu, Sep 17, 7:56 PM

usr.sbin/bhyve/bhyve.8
349	I think the SIGNAL HANDLING section should also explain how signal handling interacts with monitor mode and the new no_reboot option. Good point, I'll spin that off into a separate revision.