Page MenuHomeFreeBSD
Differential D55316

witness: report a thread that can't sleep in WITNESS_WARN
ClosedPublic
Actions

Authored by glebius on Feb 16 2026, 10:55 PM.
Tags
None
Referenced Files
F166958694: D55316.id173211.diff
Tue, Aug 18, 3:52 AM
Unknown Object (File)
Mon, Aug 17, 9:26 PM
Unknown Object (File)
Mon, Aug 17, 9:49 AM
Unknown Object (File)
Thu, Aug 13, 12:54 AM
Unknown Object (File)
Wed, Aug 12, 1:24 PM
Unknown Object (File)
Wed, Aug 12, 12:06 AM
Unknown Object (File)
Mon, Aug 10, 8:42 AM
Unknown Object (File)
Mon, Aug 10, 6:58 AM
View All 77 Files
Subscribers
imp
olce
pouria

Details

Reviewers
kib
markj
Commits
rG6feb16b77e7d: witness: report a thread that can't sleep in WITNESS_WARN
Summary

Although this is not related to locking, but seems to be the right
place to catch violators, given that WITNESS_WARN is already used
widely in the kernel.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71206
Build 68089: arc lint + arc unit

Event Timeline

glebius created this revision.Feb 16 2026, 10:55 PM
Herald added subscribers: olce, imp. · View Herald TranscriptFeb 16 2026, 10:55 PM
glebius requested review of this revision.Feb 16 2026, 10:55 PM
Harbormaster completed remote builds in B70717: Diff 172034.Feb 16 2026, 10:55 PM
glebius added a comment.Feb 16 2026, 10:56 PM

Immediately caught in bridge(4):

NET_EPOCH_ENTER(et);

callout_drain(&sc->sc_brcallout);
glebius added a subscriber: pouria.Feb 16 2026, 10:56 PM
kib accepted this revision.Feb 17 2026, 2:53 AM
kib added inline comments.
sys/kern/subr_witness.c
2140

IMO it is cleaner to inline THREAD_CAN_SLEEP() because the whole function operates on td.
The right hand of && is not style-compliant.

This revision is now accepted and ready to land.Feb 17 2026, 2:53 AM
markj accepted this revision.Feb 17 2026, 2:43 PM
markj added inline comments.
sys/kern/subr_witness.c
2144
pouria added a comment.Feb 23 2026, 5:53 PM
In D55316#1265083, @glebius wrote:

Immediately caught in bridge(4):

NET_EPOCH_ENTER(et);

callout_drain(&sc->sc_brcallout);

Are we waiting for this?
Do you want me to work on bridge?

glebius updated this revision to Diff 173211.Mar 5 2026, 6:42 PM
  • Apply Kostik's & Mark's suggestions
This revision now requires review to proceed.Mar 5 2026, 6:42 PM
Harbormaster completed remote builds in B71206: Diff 173211.Mar 5 2026, 6:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 5 2026, 6:44 PM
Closed by commit rG6feb16b77e7d: witness: report a thread that can't sleep in WITNESS_WARN (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG6feb16b77e7d: witness: report a thread that can't sleep in WITNESS_WARN.

Revision Contents
Changeset List

PathSize
sys/
kern/
9 lines

Diff 173211

View Options

sys/kern/subr_witness.c

Loading...