Page MenuHomeFreeBSD

Retire dialog
Needs ReviewPublic

Authored by des on Sat, Feb 21, 11:27 PM.
Tags
None
Referenced Files
F146012354: D55424.id.diff
Fri, Feb 27, 12:53 AM
Unknown Object (File)
Tue, Feb 24, 8:00 PM
Unknown Object (File)
Tue, Feb 24, 6:27 PM
Unknown Object (File)
Tue, Feb 24, 5:05 PM
Unknown Object (File)
Tue, Feb 24, 2:20 PM
Unknown Object (File)
Mon, Feb 23, 9:53 PM
Unknown Object (File)
Mon, Feb 23, 9:53 PM

Details

Reviewers
dteske
Group Reviewers
srcmgr
Summary

This is the last remaining piece of GPL software in the base system.
The installer transitioned to bsddialog four years ago, and the last
remaining dialog consumer, dpv, was turned off more than two years ago.
Retire dpv, libdpv, libfigpar (used only by dpv), and dialog itself.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70862
Build 67745: arc lint + arc unit

Event Timeline

des requested review of this revision.Sat, Feb 21, 11:27 PM

Why cdialog and not libdialog in the message?

Why cdialog and not libdialog in the message?

That's the real name of the software package from which we got libdialog and the dialog utility.

As far as I can tell Thomas E. Dickey just calls it dialog. cdialog appears in the "Early History" section in https://invisible-island.net/dialog/#history_details, in our ports tree, and in some tooling in the package to support renaming.

Ah, from the readme,

-(1999-12-25)-------------------------------------------------------------------
This version of dialog, formerly known as cdialog is based on the Debian
package for dialog 0.9a (see CHANGES for recent modifications)

The port is still called cdialog.

Ok, but we're removing it from the base system, not the port.

I also don't think anyone would know what "cdialog" is, but we all know what dialog is. Do we want to move dpv and friends to ports first? Maybe Cy can create new git repos for dpv + libdpv + libfigpar and a port to install them?

In D55424#1269838, @jhb wrote:

Do we want to move dpv and friends to ports first?

I'm waiting to hear back from @dteske before I do anything.

des retitled this revision from Retire cdialog to Retire dialog.Wed, Feb 25, 6:01 PM
des edited the summary of this revision. (Show Details)
des added inline comments.
.github/CODEOWNERS
65

Note, I was never the maintainer of libfigpar. I have no idea why I'm listed as such here.