Switch net.inet6.ip6.use_stableaddr to on by default
ClosedPublic
Actions

Authored by madpilot on Thu, Feb 5, 9:15 PM.

Details

Reviewers

pouria
hrs
cognet
brooks
zlei
glebius

Commits

rGa2eb0894b79b: sys/netinet6: switch net.inet6.ip6.use_stableaddr to on by default

Summary

As suggested by pouria on the current mailing list, I'm proposing
apatch to switch the ddefault for RFC 7217 stableaddress support
to on.

I also wrote an UPDATING note, I hope the wording is correct and
clear enough.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 70489
Build 67372: arc lint + arc unit

Event Timeline

madpilot created this revision.Thu, Feb 5, 9:15 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptThu, Feb 5, 9:15 PM

madpilot requested review of this revision.Thu, Feb 5, 9:15 PM

Harbormaster completed remote builds in B70454: Diff 171291.Thu, Feb 5, 9:15 PM

LGTM

This revision is now accepted and ready to land.Thu, Feb 5, 9:17 PM

No objections from me, I rather agree. But I am not enough expert in IPv6 to make a strong judgement on defaults change.

Herald added a subscriber: glebius. · View Herald TranscriptFri, Feb 6, 6:11 PM

This is a behavior change. Please also add a meta Relnotes: yes to the commit message.

The patch I submitted was missing a part. This is the updated and correct version.

@zlei Thanks for the suggestion, I'll add that to the commit message.

This revision now requires review to proceed.Sat, Feb 7, 12:36 PM

Harbormaster completed remote builds in B70489: Diff 171404.Sat, Feb 7, 12:36 PM

zlei added inline comments.Sun, Feb 8, 5:19 AM

sys/netinet6/in6_proto.c

314

This change is not necessary but harmless. I'd suggest you do not change it, to avoid potential confusion.

The val argument of SYSCTL_BOOL function only when the argument ptr is NULL. If not then that argument does nothing.

See the comment above SYSCTL_BOOL in sys/sys/sysctl.h,

/* Oid for a bool.  If ptr is NULL, val is returned. */
#define SYSCTL_NULL_BOOL_PTR ((bool *)NULL)
#define SYSCTL_BOOL(parent, nbr, name, access, ptr, val, descr) \
        SYSCTL_OID(parent, nbr, name,                           \
            CTLTYPE_U8 | CTLFLAG_MPSAFE | (access),             \
            ptr, val, sysctl_handle_bool, "CU", descr);         \
        CTASSERT(((access) & CTLTYPE) == 0 &&                   \
            sizeof(bool) == sizeof(*(ptr)))

madpilot planned changes to this revision.Sun, Feb 8, 9:01 AM

madpilot added inline comments.

sys/netinet6/in6_proto.c
314	This change is not necessary but harmless. I'd suggest you do not change it, to avoid potential confusion. The `val` argument of SYSCTL_BOOL function only when the argument `ptr` is NULL. If not then that argument does nothing. Thanks for the explanation, I was, in fact, confused by this duplication. Fixing the review shortly.