Page MenuHomeFreeBSD
Differential D54926

acpi: Move sysctl tree set up at end of initialization
ClosedPublic
Actions

Authored by olce on Jan 28 2026, 12:44 PM.
Tags
None
Referenced Files
F170759078: D54926.diff
Sun, Sep 6, 11:16 AM
Unknown Object (File)
Fri, Sep 4, 1:54 PM
Unknown Object (File)
Fri, Sep 4, 11:22 AM
Unknown Object (File)
Thu, Sep 3, 1:06 PM
Unknown Object (File)
Thu, Sep 3, 9:18 AM
Unknown Object (File)
Thu, Sep 3, 5:53 AM
Unknown Object (File)
Thu, Sep 3, 5:28 AM
Unknown Object (File)
Thu, Sep 3, 3:38 AM
View All 79 Files
Subscribers
imp

Details

Reviewers
obiwac
jhb
imp
Commits
rG7f031c9f6b9f: acpi: Move sysctl tree set up at end of initialization
Summary

Setting up the sysctl tree later:

  1. Fixes not de-registering sysctl knobs on failure to attach.
  2. Avoids having inconsistent knob values exposed during a brief moment.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70183
Build 67066: arc lint + arc unit

Event Timeline

olce created this revision.Jan 28 2026, 12:44 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 28 2026, 12:44 PM
olce requested review of this revision.Jan 28 2026, 12:44 PM
Harbormaster completed remote builds in B70183: Diff 170638.Jan 28 2026, 12:44 PM
olce mentioned this in D54626: acpi: 'hw.acpi.s4bios' sysctl: Change type to bool, expand description.Jan 28 2026, 12:47 PM
olce added a child revision: D54626: acpi: 'hw.acpi.s4bios' sysctl: Change type to bool, expand description.Jan 28 2026, 1:36 PM
imp accepted this revision.Jan 28 2026, 2:17 PM

This move is good

sys/dev/acpica/acpi.c
597

Not sure this needs a comment

This revision is now accepted and ready to land.Jan 28 2026, 2:17 PM
olce marked an inline comment as done.Jan 28 2026, 4:31 PM
olce added inline comments.
sys/dev/acpica/acpi.c
597

Yeah, I'll remove that.

olce marked an inline comment as done.Feb 2 2026, 8:39 PM
obiwac accepted this revision.Feb 3 2026, 3:12 PM
Closed by commit rG7f031c9f6b9f: acpi: Move sysctl tree set up at end of initialization (authored by olce). · Explain WhyFeb 3 2026, 5:20 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG7f031c9f6b9f: acpi: Move sysctl tree set up at end of initialization.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
121 lines

Diff 170638

View Options

sys/dev/acpica/acpi.c

Loading...