Differential D53586

vmm: Move common accessors and vm_eventinfo into sys/dev/vmm
ClosedPublic
Actions

Authored by markj on Nov 4 2025, 4:40 PM.

Tags

None

Referenced Files

	F157906959: D53586.diff
	Tue, May 26, 9:09 AM

	Unknown Object (File)
	Fri, May 22, 8:41 PM

	Unknown Object (File)
	Thu, May 21, 10:08 PM

	Unknown Object (File)
	Wed, May 13, 6:53 PM

	Unknown Object (File)
	Wed, May 13, 6:52 PM

	Unknown Object (File)
	Wed, May 13, 6:51 PM

	Unknown Object (File)
	Sun, May 3, 5:50 PM

	Unknown Object (File)
	Tue, Apr 28, 2:58 AM

View All 52 Files

Subscribers

Details

Reviewers

andrew
manu

Group Reviewers

Commits

rG7c0d94051b65: vmm: Move common accessors and vm_eventinfo into sys/dev/vmm
rG5f13d6b60740: vmm: Move common accessors and vm_eventinfo into sys/dev/vmm

Summary

Now that struct vm and struct vcpu are defined in headers, provide
inline accessors. We could just remove the accessors outright, but they
don't hurt and it would result in unneeded churn.

As a part of this, consolidate definitions related to struct
vm_eventinfo as well. I'm not sure if struct vm_eventinfo is really
needed now that vmmops_run implementations can directly access vm and
vcpu fields.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68417
Build 65300: arc lint + arc unit

Event Timeline

markj created this revision.Nov 4 2025, 4:40 PM

Herald added a reviewer: andrew. · View Herald TranscriptNov 4 2025, 4:40 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, bcran, rgrimes and 2 others. · View Herald Transcript

markj requested review of this revision.Nov 4 2025, 4:40 PM

markj added a parent revision: D53585: vmm: Deduplicate VM and vCPU state management code.

Harbormaster completed remote builds in B68417: Diff 165838.Nov 4 2025, 4:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2026, 9:58 PM

Closed by commit rG5f13d6b60740: vmm: Move common accessors and vm_eventinfo into sys/dev/vmm (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG5f13d6b60740: vmm: Move common accessors and vm_eventinfo into sys/dev/vmm.

markj added a commit: rG7c0d94051b65: vmm: Move common accessors and vm_eventinfo into sys/dev/vmm.Mar 31 2026, 4:00 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

41 lines

vmm/

io/

1 line

37 lines

1 line

arm64/

include/

29 lines

vmm/

io/

2 lines

37 lines

2 lines

dev/

vmm/

2 lines

67 lines

riscv/

include/

30 lines

vmm/

40 lines

Diff 165838

sys/amd64/include/vmm.h

Loading...

sys/amd64/vmm/io/vhpet.c

Loading...

sys/amd64/vmm/vmm.c

Loading...

sys/amd64/vmm/vmm_ioport.c

Loading...

sys/arm64/include/vmm.h

Loading...

sys/arm64/vmm/io/vtimer.c

Loading...

sys/arm64/vmm/vmm.c

Loading...

sys/arm64/vmm/vmm_reset.c

Loading...

sys/dev/vmm/vmm_stat.h

Loading...

sys/dev/vmm/vmm_vm.h

Loading...

sys/riscv/include/vmm.h

Loading...

sys/riscv/vmm/vmm.c

Loading...