bridge: Set member_ifaddrs=1 by default
ClosedPublic
Actions

Authored by ivy on Sep 2 2025, 10:05 AM.

Details

Reviewers

jrtc27
kp
netchild
bz
markj

Group Reviewers

network
bridge

Commits

rG93a734f07a22: bridge: Set member_ifaddrs=1 by default

Summary

We aren't ready to release with this set to 0: there's no solution for
running DHCP on a bridge from a devd hook, there are missing edge cases
like network boot with the boot interface in a bridge, and third-party
tools (e.g., vm-bhyve) still direct users to use the incorrect
configuration and/or don't support the correct configuration.

Keep the default value as 0 in main, but set it to 1 for stable/15 so
users and developers have advance warning to migrate.

This is a direct commit to stable/15.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66755
Build 63638: arc lint + arc unit

Event Timeline

ivy created this revision.Sep 2 2025, 10:05 AM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptSep 2 2025, 10:05 AM

ivy requested review of this revision.Sep 2 2025, 10:05 AM

Harbormaster completed remote builds in B66755: Diff 161365.Sep 2 2025, 10:05 AM

ivy mentioned this in D51156: 15.0R/relnotes: Add breaking bridge changes.Sep 2 2025, 10:06 AM

ivy added a parent revision: D52335: bridge: Print a warning if member_ifaddrs=1.

Please commit this to main, it’s not appropriate to leave that broken

In D52336#1194967, @jrtc27 wrote:

Please commit this to main, it’s not appropriate to leave that broken

I tend to agree. Even on main this change is pretty disruptive. For now I just set this sysctl manually since it's not very easy to work around some of the fallout related to DHCP.

This revision is now accepted and ready to land.Sep 2 2025, 4:56 PM

based on feedback, i will land this in main unless anyone objects. however, it depends on D52335 which no one has reviewed yet.

Closed by commit rG93a734f07a22: bridge: Set member_ifaddrs=1 by default (authored by ivy). · Explain WhySep 4 2025, 4:48 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG93a734f07a22: bridge: Set member_ifaddrs=1 by default.