Paths

Table of Contentst

Differential D50832

stand: Add support for `print_delay` environment variable in loader
ClosedPublic
Actions

Authored by obiwac on Jun 13 2025, 1:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 9, 5:45 PM

	Unknown Object (File)
	Wed, Sep 9, 5:45 PM

	Unknown Object (File)
	Tue, Sep 8, 11:32 PM

	Unknown Object (File)
	Tue, Sep 8, 11:31 PM

	Unknown Object (File)
	Tue, Sep 8, 4:18 PM

	Unknown Object (File)
	Tue, Sep 8, 8:43 AM

	Unknown Object (File)
	Mon, Sep 7, 12:10 AM

	Unknown Object (File)
	Sun, Sep 6, 9:44 AM

Subscribers

Details

Reviewers

markj
imp
manu
ziaee
mckusick
jrm

Commits

rG860f20cc133c: stand: Add print_delay environment variable in loader

Summary

This adds support for a new print_delay environment variable, which inserts a delay (in microseconds, maybe this should be in millis instead?) when putchar encounters a newline character. This can be useful when debugging.

Sponsored by: The FreeBSD Foundation

Test Plan

Just tested in loader.efi, on my machine & in VM.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64860
Build 61743: arc lint + arc unit

Event Timeline

obiwac created this revision.Jun 13 2025, 1:14 PM

Herald added a reviewer: manu. · View Herald TranscriptJun 13 2025, 1:14 PM

Herald added subscribers: ziaee, dab, bcran. · View Herald Transcript

obiwac requested review of this revision.Jun 13 2025, 1:14 PM

Harbormaster completed remote builds in B64844: Diff 156965.Jun 13 2025, 1:14 PM

Let me know if it's not desirable to add new error codes to libsa.

For my taste it's a bit gratuitous--EINVAL should be fine. I'd think that we want to avoid adding new error strings in memory-constrained loader, but Warner has better intuition there.

stand/common/misc.c
216 ↗	(On Diff #156965)
222 ↗	(On Diff #156965)	Why not have this function in console.c? Then you don't need to export print_delay_usec.

I tend to think the new error values are a bit gratuitous as well... strtonum is approximately what we're doing and it return ERANGE or EINVAL.

stand/common/misc.c
222 ↗	(On Diff #156965)	and the print_delay_usec variable...

Move setprint_delay to console.c

Harbormaster completed remote builds in B64856: Diff 157002.Jun 13 2025, 7:46 PM

Replace ENAN and ENUMNEG errors with existing EINVAL

Harbormaster completed remote builds in B64858: Diff 157005.Jun 13 2025, 7:57 PM

imp accepted this revision.Jun 13 2025, 8:00 PM

This revision is now accepted and ready to land.Jun 13 2025, 8:00 PM

markj accepted this revision.Jun 13 2025, 8:04 PM

markj added inline comments.

stand/common/console.c
47

Fix suggestions by ziaee@

This revision now requires review to proceed.Jun 14 2025, 1:58 AM

Harbormaster completed remote builds in B64859: Diff 157014.Jun 14 2025, 1:58 AM

fix markj comment & ziaee

Harbormaster completed remote builds in B64860: Diff 157015.Jun 14 2025, 2:07 AM

Doc LGTM!

ziaee accepted this revision.Jun 14 2025, 4:25 AM

This revision is now accepted and ready to land.Jun 14 2025, 4:25 AM

Rene and John Grafton helped with the doc also in the hacker lounge.

obiwac edited the summary of this revision. (Show Details)Jul 20 2025, 11:22 AM

obiwac added reviewers: mckusick, jrm.

Review process is complete with all the right folks signing off.

Closed by commit rG860f20cc133c: stand: Add print_delay environment variable in loader (authored by obiwac). · Explain WhyJul 21 2025, 2:34 PM

This revision was automatically updated to reflect the committed changes.

obiwac added a commit: rG860f20cc133c: stand: Add print_delay environment variable in loader.

Revision Contents
Changeset List

Path

Size

stand/

common/

2 lines

23 lines

defaults/

2 lines

6 lines

efi/

loader/

3 lines

Diff 157015

stand/common/bootstrap.h

Loading...

stand/common/console.c

Loading...

stand/defaults/loader.conf

Loading...

stand/defaults/loader.conf.5

Loading...

stand/efi/loader/main.c

Loading...