Page MenuHomeFreeBSD
Differential D47714

livedump: Silence KASAN and KMSAN when livedumping
ClosedPublic
Actions

Authored by markj on Nov 23 2024, 4:32 PM.
Tags
None
Referenced Files
F160491420: D47714.id146864.diff
Thu, Jun 25, 1:53 AM
Unknown Object (File)
Mon, Jun 22, 12:28 AM
Unknown Object (File)
Sat, Jun 20, 6:49 AM
Unknown Object (File)
Fri, Jun 19, 10:20 PM
Unknown Object (File)
Fri, Jun 19, 10:19 PM
Unknown Object (File)
May 14 2026, 12:36 PM
Unknown Object (File)
May 14 2026, 11:14 AM
Unknown Object (File)
May 4 2026, 6:58 PM
View All Files
Subscribers
imp
olce

Details

Reviewers
khng
mhorne
Commits
rG8e3c0a69fed2: livedump: Silence KASAN and KMSAN when livedumping
rG37cef00192ef: livedump: Silence KASAN and KMSAN when livedumping
Summary

The livedumper triggers reports from both of these sanitizers since it
necessarily accesses uninitialized or freed memory. Add a flag to
silence reports from both sanitizers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60746
Build 57630: arc lint + arc unit

Event Timeline

markj created this revision.Nov 23 2024, 4:32 PM
Herald added subscribers: olce, imp. · View Herald TranscriptNov 23 2024, 4:32 PM
markj requested review of this revision.Nov 23 2024, 4:32 PM
Harbormaster completed remote builds in B60742: Diff 146864.Nov 23 2024, 4:32 PM
markj added a child revision: D47715: savecore: Add a livedump regression test.Nov 23 2024, 4:32 PM
khng accepted this revision.Nov 23 2024, 4:43 PM
This revision is now accepted and ready to land.Nov 23 2024, 4:43 PM
markj updated this revision to Diff 146885.Nov 24 2024, 3:45 PM

Check for curthread == NULL, which can happen while APs are executing
init_secondary().

This revision now requires review to proceed.Nov 24 2024, 3:45 PM
Harbormaster completed remote builds in B60746: Diff 146885.Nov 24 2024, 3:45 PM
khng accepted this revision.Nov 24 2024, 6:48 PM
This revision is now accepted and ready to land.Nov 24 2024, 6:48 PM
mhorne accepted this revision.Nov 25 2024, 5:48 PM

Makes sense to me.

Closed by commit rG37cef00192ef: livedump: Silence KASAN and KMSAN when livedumping (authored by markj). · Explain WhyNov 25 2024, 9:13 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG37cef00192ef: livedump: Silence KASAN and KMSAN when livedumping.
markj added a commit: rG8e3c0a69fed2: livedump: Silence KASAN and KMSAN when livedumping.Dec 13 2024, 1:45 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines
3 lines
6 lines
sys/
1 line

Diff 146885

View Options

sys/kern/kern_vnodedumper.c

Loading...
View Options

sys/kern/subr_asan.c

Loading...
View Options

sys/kern/subr_msan.c

Loading...
View Options

sys/sys/proc.h

Loading...