Page MenuHomeFreeBSD

uart/ns8250: Tweak printfs to always prefix messages with uart:
ClosedPublic

Authored by imp on Fri, Oct 11, 9:53 PM.
Tags
None
Referenced Files
F100194578: D47073.diff
Mon, Oct 14, 11:20 PM
F100048197: D47073.id.diff
Mon, Oct 14, 8:31 AM
Unknown Object (File)
Sun, Oct 13, 1:01 AM
Unknown Object (File)
Sat, Oct 12, 4:12 PM
Unknown Object (File)
Sat, Oct 12, 2:56 PM
Subscribers
None

Details

Summary

It can be confusing when the ns8250 driver prints error messages with
just ns8250 as the prefix. Add uart: to the live and commented out
printfs.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Fri, Oct 11, 9:53 PM
imp created this revision.

Seems like it'd be easy enough to plumb the device_t in here and use device_printf()...

This revision is now accepted and ready to land.Sat, Oct 12, 2:50 PM

Seems like it'd be easy enough to plumb the device_t in here and use device_printf()...

Except that some (all?) of these routines may be used as part of early console where no device_t exists (though maybe we don't flush there, it's a generic interface).
And that would be a lot of replumbing in every single client uart driver.
It might be worth doing in the fullness of time, but it's a much better project than I want to bite off here to make this more correct (since the lines will be proximately close to the uart probe messages typically.
I'll add it to the list of backlog items for uart...