Page MenuHomeFreeBSD
Differential D47081

acpidump: Sort signature ifs alphabetically and make table driven
ClosedPublic
Actions

Authored by imp on Oct 11 2024, 9:54 PM.
Tags
None
Referenced Files
F172200288: D47081.id144829.diff
Wed, Sep 16, 7:48 PM
F172198349: D47081.diff
Wed, Sep 16, 7:22 PM
F172198263: D47081.diff
Wed, Sep 16, 7:21 PM
Unknown Object (File)
Thu, Sep 10, 9:44 AM
Unknown Object (File)
Tue, Sep 8, 7:29 PM
Unknown Object (File)
Sun, Sep 6, 4:10 PM
Unknown Object (File)
Sat, Sep 5, 1:16 PM
Unknown Object (File)
Sat, Sep 5, 12:19 PM
View All Files
Subscribers
None

Details

Reviewers
markj
andrew
adrian
jhb
jrtc27
bz
marius
oh
manu
kevans
cperciva
mhorne
mw
mmel
Commits
rGe9ab827df94f: acpidump: Sort signature ifs alphabetically and make table driven
Summary

Sort the ACPI signatures alphabetically and move it into a table we can iterate through

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59977
Build 56862: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 11 2024, 9:54 PM
imp created this revision.
Harbormaster completed remote builds in B59928: Diff 144685.Oct 11 2024, 9:54 PM
imp added a parent revision: D47080: acpidump: Document the alphabit soup of ACPI Table names.Oct 11 2024, 9:54 PM
imp added a child revision: D47082: acpidump: Add -T TBLN to print a specific ACPI fixed table.
markj accepted this revision.Oct 12 2024, 2:58 PM
This revision is now accepted and ready to land.Oct 12 2024, 2:58 PM
andrew accepted this revision.Oct 14 2024, 12:04 PM
imp updated this revision to Diff 144829.Oct 14 2024, 4:28 PM

table driven

This revision now requires review to proceed.Oct 14 2024, 4:28 PM
Harbormaster completed remote builds in B59977: Diff 144829.Oct 14 2024, 4:28 PM
imp retitled this revision from acpidump: Sort signature ifs alphabetically to acpidump: Sort signature ifs alphabetically and make table driven.Oct 14 2024, 4:29 PM
imp edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2024, 11:24 AM
Closed by commit rGe9ab827df94f: acpidump: Sort signature ifs alphabetically and make table driven (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGe9ab827df94f: acpidump: Sort signature ifs alphabetically and make table driven.

Revision Contents
Changeset List

PathSize
usr.sbin/
acpi/
acpidump/
87 lines

Diff 144829

View Options

usr.sbin/acpi/acpidump/acpi.c

Loading...