Page MenuHomeFreeBSD
Differential D47081

acpidump: Sort signature ifs alphabetically and make table driven
ClosedPublic
Actions

Authored by imp on Oct 11 2024, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 1:44 PM
Unknown Object (File)
Feb 22 2025, 2:17 PM
Unknown Object (File)
Feb 22 2025, 1:42 PM
Unknown Object (File)
Feb 22 2025, 1:38 PM
Unknown Object (File)
Feb 5 2025, 4:32 PM
Unknown Object (File)
Jan 30 2025, 3:00 AM
Unknown Object (File)
Jan 15 2025, 1:08 AM
Unknown Object (File)
Jan 13 2025, 6:19 AM
View All 34 Files
Subscribers
None

Details

Reviewers
markj
andrew
adrian
jhb
jrtc27
bz
marius
oh
manu
kevans
cperciva
mhorne
mw
mmel
Commits
rGe9ab827df94f: acpidump: Sort signature ifs alphabetically and make table driven
Summary

Sort the ACPI signatures alphabetically and move it into a table we can iterate through

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59928
Build 56813: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 11 2024, 9:54 PM
imp created this revision.
Harbormaster completed remote builds in B59928: Diff 144685.Oct 11 2024, 9:54 PM
imp added a parent revision: D47080: acpidump: Document the alphabit soup of ACPI Table names.Oct 11 2024, 9:54 PM
imp added a child revision: D47082: acpidump: Add -T TBLN to print a specific ACPI fixed table.
markj accepted this revision.Oct 12 2024, 2:58 PM
This revision is now accepted and ready to land.Oct 12 2024, 2:58 PM
andrew accepted this revision.Oct 14 2024, 12:04 PM
imp updated this revision to Diff 144829.Oct 14 2024, 4:28 PM

table driven

This revision now requires review to proceed.Oct 14 2024, 4:28 PM
Harbormaster completed remote builds in B59977: Diff 144829.Oct 14 2024, 4:28 PM
imp retitled this revision from acpidump: Sort signature ifs alphabetically to acpidump: Sort signature ifs alphabetically and make table driven.Oct 14 2024, 4:29 PM
imp edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2024, 11:24 AM
Closed by commit rGe9ab827df94f: acpidump: Sort signature ifs alphabetically and make table driven (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGe9ab827df94f: acpidump: Sort signature ifs alphabetically and make table driven.

Revision Contents
Changeset List

PathSize
usr.sbin/
acpi/
acpidump/
32 lines

Diff 144685

View Options

usr.sbin/acpi/acpidump/acpi.c

Show First 20 Lines • Show All 1,401 Lines • ▼ Show 20 Linesdointr(unsigned int interval, int reps)
xo_close_container("interrupt-statistics"); xo_close_container("interrupt-statistics");
} }
static void static void
domemstat_malloc(void) domemstat_malloc(void)
{ {
struct memory_type_list *mtlp; struct memory_type_list *mtlp;
struct memory_type *mtp; struct memory_type *mtp;
int error, first, i; size_t i, zones;
int error, first;
mtlp = memstat_mtl_alloc(); mtlp = memstat_mtl_alloc();
if (mtlp == NULL) { if (mtlp == NULL) {
xo_warn("memstat_mtl_alloc"); xo_warn("memstat_mtl_alloc");
return; return;
} }
if (kd == NULL) { if (kd == NULL) {
if (memstat_sysctl_malloc(mtlp, 0) < 0) { if (memstat_sysctl_malloc(mtlp, 0) < 0) {
xo_warnx("memstat_sysctl_malloc: %s", xo_warnx("memstat_sysctl_malloc: %s",
memstat_strerror(memstat_mtl_geterror(mtlp))); memstat_strerror(memstat_mtl_geterror(mtlp)));
return; return;
} }
markjUnsubmitted
Not Done
Inline Actions

This won't work if running against a vmcore.

markj: This won't work if running against a vmcore.
} else { } else {
if (memstat_kvm_malloc(mtlp, kd) < 0) { if (memstat_kvm_malloc(mtlp, kd) < 0) {
error = memstat_mtl_geterror(mtlp); error = memstat_mtl_geterror(mtlp);
if (error == MEMSTAT_ERROR_KVM) if (error == MEMSTAT_ERROR_KVM)
xo_warnx("memstat_kvm_malloc: %s", xo_warnx("memstat_kvm_malloc: %s",
kvm_geterr(kd)); kvm_geterr(kd));
else else
xo_warnx("memstat_kvm_malloc: %s", xo_warnx("memstat_kvm_malloc: %s",
memstat_strerror(error)); memstat_strerror(error));
} }
} }
xo_open_container("malloc-statistics"); xo_open_container("malloc-statistics");
xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n", xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n",
"Type", "InUse", "MemUse", "HighUse", "Requests"); "Type", "InUse", "MemUse", "HighUse", "Requests");
xo_open_list("memory"); xo_open_list("memory");
zones = memstat_malloc_zone_get_count();
for (mtp = memstat_mtl_first(mtlp); mtp != NULL; for (mtp = memstat_mtl_first(mtlp); mtp != NULL;
mtp = memstat_mtl_next(mtp)) { mtp = memstat_mtl_next(mtp)) {
if (memstat_get_numallocs(mtp) == 0 && if (memstat_get_numallocs(mtp) == 0 &&
memstat_get_count(mtp) == 0) memstat_get_count(mtp) == 0)
continue; continue;
xo_open_instance("memory"); xo_open_instance("memory");
xo_emit("{k:type/%13s/%s} {:in-use/%5ju} " xo_emit("{k:type/%13s/%s} {:in-use/%5ju} "
"{:memory-use/%5ju}{U:K} {:high-use/%7s} " "{:memory-use/%5ju}{U:K} {:high-use/%7s} "
"{:requests/%8ju} ", "{:requests/%8ju} ",
memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp), memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp),
((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-", ((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-",
(uintmax_t)memstat_get_numallocs(mtp)); (uintmax_t)memstat_get_numallocs(mtp));
first = 1; first = 1;
xo_open_list("size"); xo_open_list("size");
for (i = 0; i < 32; i++) { for (i = 0; i < zones; i++) {
if (memstat_get_sizemask(mtp) & (1 << i)) { if (memstat_malloc_zone_used(mtp, i)) {
if (!first) if (!first)
xo_emit(","); xo_emit(",");
xo_emit("{l:size/%d}", 1 << (i + 4)); xo_emit("{l:size/%d}", memstat_malloc_zone_get_size(i));
first = 0; first = 0;
} }
} }
xo_close_list("size"); xo_close_list("size");
xo_close_instance("memory"); xo_close_instance("memory");
xo_emit("\n"); xo_emit("\n");
} }
xo_close_list("memory"); xo_close_list("memory");
▲ Show 20 Lines • Show All 242 Lines • Show Last 20 Lines