uio: Use switch statements when handling UIO_READ vs UIO_WRITE
ClosedPublic
Actions

Authored by jhb on May 9 2024, 6:04 PM.

Details

Reviewers

kib
brooks
andrew
manu
emaste

Commits

rG13e770f1f0eb: uio: Use switch statements when handling UIO_READ vs UIO_WRITE
rG473c90ac04ce: uio: Use switch statements when handling UIO_READ vs UIO_WRITE

Summary

This is mostly to reduce the diff with CheriBSD which adds additional
constants to enum uio_rw, but also matches the normal style used for
uio_segflg.

Obtained from: CheriBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57643
Build 54531: arc lint + arc unit

Event Timeline

jhb created this revision.May 9 2024, 6:04 PM

Herald added a reviewer: andrew. · View Herald TranscriptMay 9 2024, 6:04 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, olce, jhibbits and 2 others. · View Herald Transcript

jhb requested review of this revision.May 9 2024, 6:04 PM

Harbormaster completed remote builds in B57642: Diff 138309.May 9 2024, 6:04 PM

Drop md.c change

Harbormaster completed remote builds in B57643: Diff 138310.May 9 2024, 6:12 PM

kib accepted this revision.May 9 2024, 8:02 PM

kib added inline comments.

sys/amd64/amd64/mem.c
123	Fix style?
sys/arm64/arm64/mem.c
91	same

This revision is now accepted and ready to land.May 9 2024, 8:02 PM

In D45142#1029592, @jhb wrote:

Drop md.c change

How come?

In D45142#1029642, @jrtc27 wrote:

In D45142#1029592, @jhb wrote:

Drop md.c change

How come?

I ended up reworking md.c to check the bio->bp_cmd instead which I think is cleaner. I haven't posted a review for that change yet but will in a bit.

jhb added inline comments.May 10 2024, 4:58 PM

sys/amd64/amd64/mem.c
123	Actually, I think I might fix kernacc to return a `bool` instead as a followup. The current function is: int kernacc(void *addr, int len, int rw) { ... if ((vm_offset_t)addr + len > vm_map_max(kernel_map) \|\| (vm_offset_t)addr + len < (vm_offset_t)addr) return (FALSE); ... return (rv == TRUE); }