Differential D44491

inpcb: fully retire inp_ppcb pointer
ClosedPublic
Actions

Authored by glebius on Mar 24 2024, 5:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 4, 7:27 PM

	Unknown Object (File)
	Sun, Oct 4, 2:59 AM

	Unknown Object (File)
	Sep 11 2026, 8:59 PM

	Unknown Object (File)
	Sep 11 2026, 8:53 PM

	Unknown Object (File)
	Sep 11 2026, 5:08 AM

	Unknown Object (File)
	Sep 11 2026, 1:23 AM

	Unknown Object (File)
	Sep 9 2026, 1:16 AM

	Unknown Object (File)
	Sep 8 2026, 11:34 PM

Subscribers

Details

Reviewers

Group Reviewers

network
transport

Commits

rG1a8d176432e7: inpcb: fully retire inp_ppcb pointer

Summary

Before a protocol specific control block started to embed inpcb in self
(see 0aa120d52f3c, e68b3792440c, 483fe96511ec) this pointer used to point
at it.

Retain kf_sock_inpcb field in the struct kinfo_file in <sys/user.h>. The
exp-run detected a minimal use of the field in ports:

sysutils/lsof - patched
net-mgmt/etdata - patch submitted upstream
emulators/qemu-user-static - upstream master branch seems not using the field anymore

We can keep the field around for some time, but eventually it may be reused
for something else.

PR: 277659 (exp-run)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56766
Build 53654: arc lint + arc unit

Event Timeline

glebius created this revision.Mar 24 2024, 5:35 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptMar 24 2024, 5:35 PM

Herald added subscribers: olce, melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Mar 24 2024, 5:35 PM

Harbormaster completed remote builds in B56766: Diff 136169.Mar 24 2024, 5:35 PM

tuexen accepted this revision as: transport, tuexen.Mar 24 2024, 6:17 PM

This revision is now accepted and ready to land.Mar 24 2024, 6:17 PM

Closed by commit rG1a8d176432e7: inpcb: fully retire inp_ppcb pointer (authored by glebius). · Explain WhyMar 29 2024, 7:20 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG1a8d176432e7: inpcb: fully retire inp_ppcb pointer.

Revision Contents
Changeset List

Path

Size

lib/

libprocstat/

1 line

29 lines

libprocstat_compat.c

2 lines

sys/

kern/

8 lines

netinet/

9 lines

9 lines

7 lines

sys/

2 lines

usr.bin/

fstat/

15 lines

systat/

28 lines

Diff 136169

lib/libprocstat/libprocstat.h

Loading...

lib/libprocstat/libprocstat.c

Loading...

lib/libprocstat/libprocstat_compat.c

Loading...

sys/kern/sys_socket.c

Loading...

sys/netinet/in_pcb.h

Loading...

sys/netinet/in_pcb.c

Loading...

sys/netinet/tcp_subr.c

Loading...

sys/sys/user.h

Loading...

usr.bin/fstat/fstat.c

Loading...

usr.bin/systat/netstat.c

Loading...