Details

Reviewers

tuexen
jtl
thj
rrs
glebius

Group Reviewers

transport

Summary

This Diff builds upon D21011. A simplistic reflector for
the received CE, ECT1 and ECT0 marked data bytes in the
AccECN TCP option - which is sent on every ACK, in full.
Only when space is needed for SACK, an abbreviated option
is constructed and sent (if possible).

Potential enhancements: Track which counters changed, and
send only changed counters repeatedly (e.g. 3 times at least)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55461
Build 52350: arc lint + arc unit

Event Timeline

rscheff created this revision.Aug 23 2022, 9:10 AM

Herald added a reviewer: transport. · View Herald TranscriptAug 23 2022, 9:10 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Aug 23 2022, 9:10 AM

Harbormaster completed remote builds in B47066: Diff 109702.Aug 23 2022, 9:10 AM

rebase to main

Harbormaster completed remote builds in B47201: Diff 110016.Aug 31 2022, 1:52 PM

validating this diff against accecn packetdrill scripts from Linux (Ilpo). Once done, will bring this up again.

move ecn sysctls to tcp_ecn.c
go with AccECN options from a compile time option to a global setting
document the new sysctl option
remove outdated comment

Harbormaster completed remote builds in B47660: Diff 111278.Sep 30 2022, 3:44 PM

rebase to main

Harbormaster completed remote builds in B47772: Diff 111633.Oct 11 2022, 8:45 AM

ensure control packets have accecn opt, if enabled

Harbormaster completed remote builds in B47838: Diff 111807.Oct 14 2022, 1:39 PM

gbe added a subscriber: gbe.Oct 26 2022, 8:46 PM

move ecn sysctls to tcp_ecn.c
go with AccECN options from a compile time option to a global setting
document the new sysctl option
remove outdated comment
add logging, and make syncache response honor most recent incoming SYN fields
add logging
more logging
ensure control packets have accecn opt, if enabled
fix packt_this_ack bug
bump man date
received accecn counter into tcpinfo
add more tcpinfo counters
make accecn option counters a struct within tcpcb, which can also be locally allocated (syncache, prior of tcpcb)
initialize to_ae properly
reference properly to counters
bump man page date
remove all logging

Harbormaster completed remote builds in B48203: Diff 112714.Nov 7 2022, 10:18 AM

add ntoh24 and hton24 to improve readability
compact AccECN opt decoding
straighten option output path

Harbormaster completed remote builds in B52102: Diff 123335.Jun 16 2023, 12:34 PM

use temp variable to improve readability

Harbormaster completed remote builds in B52108: Diff 123352.Jun 16 2023, 6:04 PM

rebase to main

Harbormaster completed remote builds in B55461: Diff 132863.Jan 17 2024, 8:09 AM

rebase main

Harbormaster completed remote builds in B56082: Diff 134552.Feb 18 2024, 10:27 AM

Commit	Tree	Parents	Author	Summary	Date
ad347bbbde1e	431cbb3a393d	4601063ba1c1	Richard Scheffenegger	no logging	Jan 17 2024, 12:05 AM
4601063ba1c1	25d8e5ded63a	8068728816fe	Richard Scheffenegger	add logging	Jun 26 2023, 10:55 AM
8068728816fe	7e2a1049910f	6a36f0005cbf	Richard Scheffenegger	fix RTO fallback	Jun 20 2023, 9:00 PM
6a36f0005cbf	431cbb3a393d	9b0bb2c12edf	Richard Scheffenegger	set TOF_ flags on input processing of AccECN option	Jun 20 2023, 8:32 PM
9b0bb2c12edf	1e3a6a2637ab	c1766c2af64a	Richard Scheffenegger	move all accecn counters into struct and add primitive overflow protection for… (Show More…)	Jun 20 2023, 5:46 PM
c1766c2af64a	05fd3da55b92	19496997ee1b	Richard Scheffenegger	move disabling AccECN option from fastpath to RTO path	Jun 20 2023, 4:32 PM
19496997ee1b	4eed5eb8d224	8c4a6562a48a	Richard Scheffenegger	disable AccECN option after multiple RTOs.	Jun 20 2023, 4:28 PM
8c4a6562a48a	2de5834305d6	79c4330f6e10	Richard Scheffenegger	keep AccECN option in tp->t_flags (fastpath; disable for traversal issues)	Jun 20 2023, 4:09 PM
79c4330f6e10	aee6139f0d49	1d7693b4247d	Richard Scheffenegger	add AccECN option to ACE flows after global option was disabled	Jun 20 2023, 11:18 AM
1d7693b4247d	5f0404d88e02	4068fba934b8	Richard Scheffenegger	use temp variable to improve readability	Jun 16 2023, 6:03 PM
4068fba934b8	57ebeb592f55	8ab8a385b653	Richard Scheffenegger	fix whitespace	Jun 16 2023, 12:33 PM
8ab8a385b653	35eb49d47f5b	7148d2f630a5	Richard Scheffenegger	straighten option output path	Jun 16 2023, 12:30 PM
7148d2f630a5	296ee84d4917	5a56122e5efc	Richard Scheffenegger	compact AccECN opt decoding	Jun 16 2023, 12:00 PM
5a56122e5efc	bab43897dae0	309475be71a4	Richard Scheffenegger	add ntoh24 and hton24 to improve readability	Jun 16 2023, 11:17 AM
309475be71a4	db4d9c84b19f	de771824776a	Richard Scheffenegger	clean up manual rebase	Jun 14 2023, 1:20 AM
de771824776a	0aadeb9cc379	3194e373a2b2	Richard Scheffenegger	remove all logging	Nov 7 2022, 10:17 AM
3194e373a2b2	eb8602c79f64	cd4d8d3cbe4b	Richard Scheffenegger	reference properly to counters	Nov 7 2022, 9:35 AM
cd4d8d3cbe4b	82b85168afa3	6f0e4e1df820	Richard Scheffenegger	initialize to_ae properly	Nov 6 2022, 4:51 PM
6f0e4e1df820	772bac0488dd	ac623100abcd	Richard Scheffenegger	make accecn option counters a struct within tcpcb, which can also be locally… (Show More…)	Nov 6 2022, 3:51 PM
ac623100abcd	e14c064922c5	9340d4102fb0	Richard Scheffenegger	add more tcpinfo counters	Nov 6 2022, 2:20 PM
9340d4102fb0	3337e35121c5	baafe2167cb7	Richard Scheffenegger	received accecn counter into tcpinfo	Nov 6 2022, 11:53 AM
baafe2167cb7	cc14f5633b93	ab4a46086493	Richard Scheffenegger	fix packt_this_ack bug	Nov 5 2022, 4:25 PM
ab4a46086493	26cf097e1f36	2a45f0ee878a	Richard Scheffenegger	ensure control packets have accecn opt, if enabled	Oct 14 2022, 1:38 PM
2a45f0ee878a	658a237892a5	03f009c3e5b5	Richard Scheffenegger	more logging	Oct 12 2022, 5:32 PM
03f009c3e5b5	a66b7907cb01	de036220018d	Richard Scheffenegger	add logging	Oct 12 2022, 4:08 PM
de036220018d	2e4f958302f3	e2e1dc0fbba4	Richard Scheffenegger	add logging, and make syncache response honor most recent incoming SYN fields	Oct 4 2022, 2:18 PM
e2e1dc0fbba4	de458243bff7	51b50c5987d7	Richard Scheffenegger	remove outdated comment	Sep 30 2022, 3:43 PM
51b50c5987d7	1ba125fadb47	27f1812f94e8	Richard Scheffenegger	document the new sysctl option	Sep 30 2022, 3:41 PM
27f1812f94e8	c9582b26002a	7c3d38f631d4	Richard Scheffenegger	go with AccECN options from a compile time option to a global setting	Sep 30 2022, 3:36 PM
7c3d38f631d4	937197f9bf56	65b03572cb86	Richard Scheffenegger	move ecn sysctls to tcp_ecn.c	Sep 30 2022, 12:42 PM
65b03572cb86	e894b56e0212	72ae7cf4ec87	Richard Scheffenegger	Implement AccECN option (w/ early assigned option number) (Show More…)	Aug 23 2022, 8:58 AM
72ae7cf4ec87	0d666e4b7f21	4e2bde044dd1	Richard Scheffenegger	add accecn-opt to syncache, and initialize values; NOTE: fixup for DATA in SYN.. (Show More…)	Aug 22 2022, 1:21 PM
4e2bde044dd1	506423a4198d	750e8ab2c32a	Richard Scheffenegger	use early assigned TCP options codepoints	Aug 7 2022, 6:41 AM
750e8ab2c32a	0619f2d0f981	91865b6bc04d	Richard Scheffenegger	make experimental AccECN option align with Linux	Jul 25 2022, 12:52 AM
91865b6bc04d	d4a5c54de024	aec5a876d956	Richard Scheffenegger	use 0xac and 0xae for AccECN option	Jul 24 2022, 3:29 PM
aec5a876d956	c31badbc397e	6214cbddae54	Richard Scheffenegger	initialize local accecn byte counters	Feb 12 2022, 11:17 PM
6214cbddae54	b5ec06e682b4	282c230dd6ac	Richard Scheffenegger	fix TCP_ACCECNOPT compile option fix experimental tcpopt	Feb 11 2022, 3:52 PM
282c230dd6ac	71d606831d93	47a6020d395a	Richard Scheffenegger	make AccECN TCP options a compile time option	Feb 11 2022, 12:37 PM
47a6020d395a	4283db2f8f08	ff4e995d612b	Richard Scheffenegger	bracket AccECN option with compile #ifdef TCP_ACCECNOPT	Feb 11 2022, 12:11 PM
ff4e995d612b	b377955814f9	d9e30ce36e41	Richard Scheffenegger	first attempt at providing AccECN option	Feb 7 2022, 2:32 AM
d9e30ce36e41	f43379466906	48295d6469b3	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
48295d6469b3	07b85e4d893b	ff4d25e17987	Richard Scheffenegger	remove logging again	Feb 6 2022, 2:14 PM
ff4d25e17987	3b0588aa8506	a5c5886eeed4	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
a5c5886eeed4	f43379466906	86891e181e97	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
86891e181e97	5a2ed5a5eace	da9ca366f5af	Richard Scheffenegger	removing logging	Jul 24 2022, 2:40 AM
da9ca366f5af	61b058b6e7b0	434ac9482d4f	Richard Scheffenegger	fixed 2 oversights, added logging	Jul 24 2022, 2:37 AM
434ac9482d4f	5a2ed5a5eace	1a47987efb27	Richard Scheffenegger	thflags is fully propulated for KASSERT fix syn-sent ecn negotiation	Feb 10 2022, 3:15 AM
1a47987efb27	123e857948ce	164d3af6cbdd	Richard Scheffenegger	cleaning up a set of KMOD_ macros, and nicifying source code	Feb 6 2022, 9:20 PM
164d3af6cbdd	07b85e4d893b	a5e0ae97f763	Richard Scheffenegger	remove logging again	Feb 6 2022, 2:14 PM
a5e0ae97f763	b69c99c17454	be476d32ecb2	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
be476d32ecb2	53b978e2a3e6	11886f3d2e43	Richard Scheffenegger	use uint16_t consistently for thflags, rather than passing pointers	Feb 2 2022, 9:13 PM
11886f3d2e43	ce9339fc39b7	9420ab88dc2b	Richard Scheffenegger	troubleshoot rack (ect0 on control packet)	Feb 2 2022, 6:48 PM
9420ab88dc2b	3ae6b0948311	f2b084e4b271	Richard Scheffenegger	fix up rack fast_output	Feb 2 2022, 4:30 PM
f2b084e4b271	82f7915e36ad	8e882a4c8c9f	Richard Scheffenegger	fixing cwr to go only with new data, update rack	Feb 2 2022, 4:13 PM
8e882a4c8c9f	ea8371f68772	a3859d9ab406	Richard Scheffenegger	do proper output handling also for parallel SYN	Feb 2 2022, 2:14 PM
a3859d9ab406	784217274b4c	fb8a67738e61	Richard Scheffenegger	proper logging when handling ecn	Feb 2 2022, 12:03 PM
fb8a67738e61	bef3fb0af41d	69f9f94a3cf2	Richard Scheffenegger	adding logging output, handle parallel SYN for ECN	Feb 2 2022, 10:05 AM
69f9f94a3cf2	b191a984096d	0d1347641757	Richard Scheffenegger	prepare rack to handle AccECN	Feb 1 2022, 1:40 PM
0d1347641757	5f4c72a08181	ccc4683fd4a5	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
ccc4683fd4a5	eea9d250c02c	bd59862b2789	Richard Scheffenegger	- rebase to main - move tcp_set_flag() past ECN in rack_fast_output()	Feb 5 2022, 8:19 PM
bd59862b2789	cf058dee009f	57e56fb995af	Richard Scheffenegger	rebase to main, set flags in rsm_fast_output after ecn changes	Feb 4 2022, 11:16 PM
57e56fb995af	c630d9b77672	58b22147cd50	Richard Scheffenegger	Add/update AccECN related statistics and numbers (Show More…)	Feb 3 2022, 8:51 PM
58b22147cd50	653a9893df4b	c6ac37a4904c	Richard Scheffenegger	reconsile recent commits with local changes	Feb 3 2022, 8:34 PM
c6ac37a4904c	203276833bf5	0494ddc08cee	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
0494ddc08cee	6a4051f97e5f	755fda332196	Richard Scheffenegger	use uint16_t consistently for thflags, rather than passing pointers	Feb 2 2022, 9:13 PM
755fda332196	1a95d59e160f	0606cb436ea9	Richard Scheffenegger	troubleshoot rack (ect0 on control packet)	Feb 2 2022, 6:48 PM
0606cb436ea9	74664239b9d1	58de5d67e54c	Richard Scheffenegger	fixing cwr to go only with new data, update rack	Feb 2 2022, 4:13 PM
58de5d67e54c	a85ef8b3aa4a	4c0e384154bd	Richard Scheffenegger	do proper output handling also for parallel SYN	Feb 2 2022, 2:14 PM
4c0e384154bd	fe9ad6b267cc	18a58ae0d5f5	Richard Scheffenegger	proper logging when handling ecn	Feb 2 2022, 12:03 PM
18a58ae0d5f5	3aa1bb71326d	551cb1f2f723	Richard Scheffenegger	adding logging output, handle parallel SYN for ECN	Feb 2 2022, 10:05 AM
551cb1f2f723	a935e11d9a84	097b2606fc80	Richard Scheffenegger	put more common ecn code to tcp_ecn.c	Feb 1 2022, 9:00 PM
097b2606fc80	3695a21476e8	d74f9ed157bc	Richard Scheffenegger	prepare rack to handle AccECN	Feb 1 2022, 1:40 PM
d74f9ed157bc	0dc33182c34c	bfd681c43446	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
bfd681c43446	f666225a87fe	c1d837ff3ec5	Richard Scheffenegger	replace all macro references	Feb 2 2022, 7:33 PM
c1d837ff3ec5	6d3fc3583705	1a104d1f164d	Richard Scheffenegger	use static inline function instead of macro	Feb 2 2022, 7:10 PM
1a104d1f164d	d5d20e6bc5f9	b802c007d9bd	Richard Scheffenegger	fix typo	Feb 1 2022, 4:21 PM
b802c007d9bd	6fc7a8a7e4ea	8d31d15ca488	Richard Scheffenegger	Access TCP Header Flags via accessor MACRO (Show More…)	Feb 1 2022, 4:06 PM
8d31d15ca488	f666225a87fe	dfa595c5dcc1	Richard Scheffenegger	only access exsting tp	Oct 13 2022, 5:50 AM
dfa595c5dcc1	8a4a72c705d0	c79265f896d1	Richard Scheffenegger	don't assume tp, thflag exist	Oct 13 2022, 5:45 AM
c79265f896d1	1d5d20c4b00a	61c831679615	Richard Scheffenegger	tcp_respond should react as expected for ECN in preparation for ECN++, AccECN	Oct 12 2022, 6:15 PM

D47063 extend the use of the th_flags accessor function

·Reviewers: tuexen, cc, transport, cy, glebius, Restricted Owners Package, shurd, ...

Mon, Nov 4, 4:11 PM

Author: rscheff

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 132863

share/man/man4/tcp.4

sys/netinet/tcp.h

sys/netinet/tcp_ecn.h

sys/netinet/tcp_ecn.c

sys/netinet/tcp_input.c

sys/netinet/tcp_output.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_syncache.c

sys/netinet/tcp_timer.c

sys/netinet/tcp_usrreq.c

sys/netinet/tcp_var.h

Implement AccECN option (w/ early assigned option number)Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 132863

share/man/man4/tcp.4

sys/netinet/tcp.h

sys/netinet/tcp_ecn.h

sys/netinet/tcp_ecn.c

sys/netinet/tcp_input.c

sys/netinet/tcp_output.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_syncache.c

sys/netinet/tcp_timer.c

sys/netinet/tcp_usrreq.c

sys/netinet/tcp_var.h

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Revision Contents
Changeset List