bhyve: Replace many fprintf(stderr, ...) calls with EPRINTLN
ClosedPublic
Actions

Authored by jhb on Oct 12 2023, 9:05 PM.

Details

Reviewers

markj
corvink

Group Reviewers

bhyve

Commits

rG506890a652aa: bhyve: Replace many fprintf(stderr, ...) calls with EPRINTLN
rG3cf142f1bc5f: bhyve: Replace many fprintf(stderr, ...) calls with EPRINTLN
rGb0936440b8fc: bhyve: Replace many fprintf(stderr, ...) calls with EPRINTLN

Summary

EPRINTLN handles newlines appropriately when stdout/stderr have been
reused as the backend for a serial port.

For bhyverun.c itself, the rule this attempts to follow is to use
regular fprintf/perror/warn/err prior to init_pci() (which is when
serial ports are configured) and to switch to EPRINTLN afterwards.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 12 2023, 9:05 PM

Herald added a reviewer: bhyve. · View Herald TranscriptOct 12 2023, 9:05 PM

Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript

jhb requested review of this revision.Oct 12 2023, 9:05 PM

jhb added a parent revision: D42181: bhyve ahci: Replace WPRINTF with EPRINTLN.

Harbormaster completed remote builds in B53955: Diff 128692.Oct 12 2023, 9:05 PM

Do you plan to convert uses of warn() as well?

This revision is now accepted and ready to land.Oct 13 2023, 2:12 PM

In D42182#962551, @markj wrote:

Do you plan to convert uses of warn() as well?

I didn't have it in my plan as that requires a bit more work. There are probably several perror calls that also still need fixing after this. I had noticed the rdmsr messages recently in a Linux guest and went for the low-hanging fruit (initially just in vmexit.c but then expanding to what my a grep of fprintf found). There might still be some fprintf calls in snapshot.c that this change doesn't address.

corvink accepted this revision.Oct 16 2023, 8:04 AM

corvink added inline comments.