Page MenuHomeFreeBSD
Differential D38926

make showconfig: set MACHINE appropriately
ClosedPublic
Actions

Authored by emaste on Mar 6 2023, 4:00 PM.
Tags
None
Referenced Files
F168847980: D38926.id.diff
Sun, Aug 30, 10:44 AM
Unknown Object (File)
Fri, Aug 28, 8:43 PM
Unknown Object (File)
Thu, Aug 27, 6:37 PM
Unknown Object (File)
Thu, Aug 27, 3:40 PM
Unknown Object (File)
Wed, Aug 26, 9:35 PM
Unknown Object (File)
Wed, Aug 26, 9:27 PM
Unknown Object (File)
Wed, Aug 26, 12:07 PM
Unknown Object (File)
Tue, Aug 25, 1:50 AM
View All Files
Subscribers
None

Details

Reviewers
imp
Commits
rGd7a491dd3037: make showconfig: set MACHINE and MACHINE_ARCH
Summary
Previously MACHINE was not set for the showconfig target, and was the
host's value rather than the target.  As a result some machine-dependent
kernel options were not reported with correct defaults in the src.conf
manpage.

PR: 269994
Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 6 2023, 4:00 PM
emaste created this revision.
emaste added inline comments.
Makefile.inc1
3380

Perhaps MACHINE_ARCH=${TARGET_ARCH} too? I notice builddtb below sets only MACHINE.

emaste updated this revision to Diff 118399.Mar 6 2023, 4:04 PM
imp accepted this revision.Mar 6 2023, 8:36 PM

Don't see that MACHINE_ARCH is used, but it's always a good idea to set MACHINE and MACHINE_ARCH in pairs.

This revision is now accepted and ready to land.Mar 6 2023, 8:36 PM
Closed by commit rGd7a491dd3037: make showconfig: set MACHINE and MACHINE_ARCH (authored by emaste). · Explain WhyMar 6 2023, 9:03 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGd7a491dd3037: make showconfig: set MACHINE and MACHINE_ARCH.

Revision Contents
Changeset List

PathSize
2 lines

Diff 118399

View Options

Makefile.inc1

Loading...