Differential D38800

abstract out the vm detection via smbios..
ClosedPublic
Actions

Authored by jmg on Feb 26 2023, 7:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 17, 5:49 AM

	Unknown Object (File)
	Wed, Apr 15, 9:15 AM

	Unknown Object (File)
	Fri, Apr 10, 9:08 PM

	Unknown Object (File)
	Tue, Apr 7, 4:41 PM

	Unknown Object (File)
	Tue, Apr 7, 1:07 AM

	Unknown Object (File)
	Mon, Apr 6, 9:17 PM

	Unknown Object (File)
	Mon, Apr 6, 2:40 PM

	Unknown Object (File)
	Wed, Apr 1, 6:28 AM

Subscribers

Details

Reviewers

jhb
stevek
imp
kib
manu

Commits

rG2fee87562948: abstract out the vm detection via smbios..

Summary

This makes the detection of VMs common between platforms that
have SMBios.

Note, I'm not sure what is correct copyright. I just added the
people who touched the code that I relocated.. Neither person had
added their own copyright to the original file.

Adding them as reviewers so they can approve/disagree w/ the
attribution.

Test Plan

Have built VMs of i386, amd64, arm64, and booted them under qemu
and verified that they all detect they are VMs. Note that I don't
have a good way to verify that i386/amd64 is using this code, as
qemu sets the HV bit in CPUID, so this code is not explicitly run.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50051
Build 46943: arc lint + arc unit

Event Timeline

jmg created this revision.Feb 26 2023, 7:07 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 26 2023, 7:07 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

jmg requested review of this revision.Feb 26 2023, 7:07 PM

Harbormaster completed remote builds in B50035: Diff 117975.Feb 26 2023, 7:07 PM

kib added inline comments.Feb 26 2023, 10:39 PM

sys/dev/smbios/smbios_subr.c
39	Please do not add these two lines for a new file.
46	I do not think this comment is needed
49
61

Modulo kib's comments.... this looks good...

This revision is now accepted and ready to land.Feb 27 2023, 4:13 AM

zlei added a subscriber: zlei.Feb 27 2023, 10:08 AM

implement kib's comments

This revision now requires review to proceed.Feb 27 2023, 11:23 PM

Harbormaster completed remote builds in B50051: Diff 118039.Feb 27 2023, 11:23 PM

done.

not sure how it included a file AFTER the commit hash, but arc is
weird.. hopefully this will work..

Harbormaster completed remote builds in B50052: Diff 118040.Feb 27 2023, 11:26 PM

kib accepted this revision.Feb 28 2023, 10:26 AM

This revision is now accepted and ready to land.Feb 28 2023, 10:26 AM

Closed by commit rG2fee87562948: abstract out the vm detection via smbios.. (authored by jmg). · Explain WhyMar 3 2023, 12:56 AM

This revision was automatically updated to reflect the committed changes.

jmg added a commit: rG2fee87562948: abstract out the vm detection via smbios...

Revision Contents
Changeset List

Path

Size

release/

scripts/

2 lines

tools/

4 lines

sys/

amd64/

amd64/

3 lines

arm64/

arm64/

4 lines

conf/

2 lines

1 line

dev/

smbios/

4 lines

104 lines

i386/

i386/

3 lines

x86/

x86/

57 lines

Diff 118039

release/scripts/mk-vmimage.sh

Loading...

release/tools/vmimage.subr

Loading...

sys/amd64/amd64/machdep.c

Loading...

sys/arm64/arm64/machdep.c

Loading...

sys/conf/files.arm64

Loading...

sys/conf/files.x86

Loading...

sys/dev/smbios/smbios.h

Loading...

sys/dev/smbios/smbios_subr.c

Loading...

sys/i386/i386/machdep.c

Loading...

sys/x86/x86/identcpu.c

Loading...