Page MenuHomeFreeBSD
Differential D37668

netlink: improve interface handling
ClosedPublic
Actions

Authored by melifaro on Dec 10 2022, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 1, 2:51 AM
Unknown Object (File)
Sat, Feb 28, 4:50 PM
Unknown Object (File)
Thu, Feb 12, 2:32 PM
Unknown Object (File)
Mon, Feb 9, 3:04 AM
Unknown Object (File)
Jan 14 2026, 11:19 AM
Unknown Object (File)
Dec 28 2025, 4:41 PM
Unknown Object (File)
Dec 28 2025, 7:12 AM
Unknown Object (File)
Dec 12 2025, 10:01 PM
View All Files
Subscribers
ae
glebius
imp

Details

Reviewers
None
Group Reviewers
network
Commits
rGdb476bbc226a: netlink: improve interface handling
rG80f03e63d67e: netlink: improve interface handling
Summary
  • Separate interface creation from interface modification code
  • Support setting some interface attributes (ifdescr, mtu, up/down, promisc)
  • Improve interaction with the cloners requiring to parse/write custom interface attributes
  • Add bitmask-based way of checking if the attribute is present in the

message

  • Don't use multipart RTM_GETLINK replies when searching for the

specific interface names

  • Use ENODEV instead of ENOENT in case of failed RTM_GETLINK search
  • Add python netlink test helpers
  • Add first netlink interface tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errortests/atf_python/sys/net/netlink.py:593E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:807E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:859E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:861E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:933E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:934E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:935E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:1006E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1122E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1127E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1138E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1148E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1148E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1151E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1151E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1155E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1404E203PEP8 E203
Errortests/sys/netlink/test_rtnl_iface.py:63E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:99E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:123E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:144E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:153E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:184E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:193E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:235E501PEP8 E501
Unit
No Test Coverage
Build Status
Buildable 48694
Build 45580: arc lint + arc unit

Event Timeline

melifaro created this revision.Dec 10 2022, 4:38 PM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptDec 10 2022, 4:38 PM
melifaro requested review of this revision.Dec 10 2022, 4:38 PM
Harbormaster completed remote builds in B48694: Diff 114035.Dec 10 2022, 4:38 PM
melifaro added a reviewer: network.Dec 14 2022, 7:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2022, 7:53 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG80f03e63d67e: netlink: improve interface handling (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG80f03e63d67e: netlink: improve interface handling.
melifaro added a commit: rGdb476bbc226a: netlink: improve interface handling.Jan 23 2023, 10:15 PM

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
share/
man/
man4/
2 lines
sys/
netlink/
28 lines
20 lines
route/
208 lines
100 lines
2 lines
15 lines
tests/
atf_python/
sys/
net/
2 lines
1495 lines
sys/
netlink/
14 lines
281 lines

Diff 114035

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

share/man/man4/rtnetlink.4

Loading...
View Options

sys/netlink/netlink_message_parser.h

Loading...
View Options

sys/netlink/netlink_message_parser.c

Loading...
View Options

sys/netlink/route/iface.c

Loading...
View Options

sys/netlink/route/iface_drivers.c

Loading...
View Options

sys/netlink/route/interface.h

Loading...
View Options

sys/netlink/route/route_var.h

Loading...
View Options

tests/atf_python/sys/net/Makefile

Loading...
View Options

tests/atf_python/sys/net/netlink.py

Loading...
View Options

tests/sys/netlink/Makefile

Loading...
View Options

tests/sys/netlink/test_rtnl_iface.py

Loading...